Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-115421: List all test/ subdirs in Makefile, and test them (GH-115813) #116498

Merged
merged 2 commits into from Mar 11, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Mar 8, 2024

This backports:

Unlike on the main branch, new directories are added to the end,
so they're a bit easier to patch out if a redistributor needs to do so.

On main & 3.12, there's a special case for idlelib/idle_test; on
3.11 TESTSUBDIRS has several more entries that are not in test/.
This backport ignores all of them (including idlelib).
(The alternative would be list them, as additions to TEST_HOME_DIR.
But that's probably too invasive; people might split stdlib up in
surprising ways.)

encukou and others added 2 commits March 8, 2024 13:30
…hem (pythonGH-115813) (pythonGH-116462)

* pythongh-115421: Test that our Makefile has all needed test folders (pythonGH-115813)
* Update the list of installed test subdirectories

---------

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou merged commit d781179 into python:3.11 Mar 11, 2024
24 checks passed
@encukou encukou deleted the 3.11-install-all-tests branch March 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants