Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118773: Use language-invariant SDDL string instead of aliases for ACLs. #118800

Merged
merged 3 commits into from
May 9, 2024
Merged

gh-118773: Use language-invariant SDDL string instead of aliases for ACLs. #118800

merged 3 commits into from
May 9, 2024

Conversation

zooba
Copy link
Member

@zooba zooba commented May 8, 2024 •
edited by bedevere-app bot

@bedevere-app bedevere-app bot mentioned this pull request May 8, 2024
Closed
@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label May 8, 2024
@Eclips4 Eclips4 mentioned this pull request May 9, 2024
Closed
@zooba zooba changed the title gh-118773: Use well-known constants instead of aliases for ACLs. gh-118773: Use language-invariant SDDL string instead of aliases for ACLs. May 9, 2024
@zooba
Copy link
Member Author

zooba commented May 9, 2024

!buildbot .windows.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit 99ae180 🤖

The command will test the builders whose names match following regular expression: .*windows.*

The builders matched are:

  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Windows Server 2022 NoGIL PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows11 Bigmem PR

@zooba
Copy link
Member Author

zooba commented May 9, 2024

FYI, this will be backported to all branches, but because the original change hasn't been merged into those yet it can't be done automatically. I'll handle it myself once this one is reviewed and merged.

@zooba
Copy link
Member Author

zooba commented May 9, 2024

The test_cext failure on ARM64 is unrelated.

eryksun
eryksun reviewed May 9, 2024
View reviewed changes
Modules/posixmodule.c Outdated Show resolved Hide resolved
eryksun
eryksun reviewed May 9, 2024
View reviewed changes
Modules/posixmodule.c Outdated Show resolved Hide resolved
@zooba zooba merged commit 8af84b5 into python:main May 9, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@zooba zooba deleted the gh-118773 branch May 9, 2024 16:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@zooba @miss-islington
pythongh-118773: Use language-invariant SDDL string instead of aliase…
571459f 
…s for ACLs. (pythonGH-118800)

(cherry picked from commit 8af84b5)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

GH-118858 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
zooba added a commit that referenced this pull request May 9, 2024
@miss-islington @zooba
gh-118773: Use language-invariant SDDL string instead of aliases for …
9d646d0 
…ACLs. (GH-118800)

(cherry picked from commit 8af84b5)

Co-authored-by: Steve Dower <steve.dower@python.org>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@zooba @SonicField
pythongh-118773: Use language-invariant SDDL string instead of aliase…
a6bc4e3 
…s for ACLs. (pythonGH-118800)
@arhadthedev arhadthedev mentioned this pull request May 12, 2024
Open
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eryksun eryksun eryksun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zooba @bedevere-bot @eryksun @Eclips4