Revert "gh-115432: Add critical section variant that handles a NULL object (#115433)" #118861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NULL object (python#115433)" This reverts commit ad4f909. The API ended up not being used.
|
@Yhg1s - this isn't really a bug fix, but it's definitely not a feature. Would it be appropriate to backport this revert to 3.13? |
colesbury
force-pushed
the
gh-115432-revert
branch
from
9f8175b
to
49a359e
Compare
|
Yeah, backporting it to 3.13 is fine until we get to rc1. |
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2024
…NULL object (pythonGH-115433)" (pythonGH-118861) This reverts commit ad4f909. The API ended up not being used. (cherry picked from commit 46c8081) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-118872 is a backport of this pull request to the 3.13 branch. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 10, 2024
…NULL object (python#115433)" (python#118861) This reverts commit ad4f909. The API ended up not being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ad4f909.
This internal API ended up not being used.
Py_BEGIN_CRITICAL_SECTIONthat accepts aNULLargument #115432