-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-80448: argparse: Fix IndexError on store_true action #15656
Conversation
cc @rhettinger |
Misc/NEWS.d/next/Library/2019-09-03-15-45-19.bpo-36267.z42Ex7.rst
Outdated
Show resolved
Hide resolved
update news by Rémi's suggestion. Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Had two nits, although the style one can be ignored cc @JelleZijlstra
Misc/NEWS.d/next/Library/2019-09-03-15-45-19.bpo-36267.z42Ex7.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Planning to merge this after CI passes, and backport to the bugfix branches. |
Thanks @shihai1991 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry @shihai1991 and @JelleZijlstra, I had trouble checking out the |
GH-99404 is a backport of this pull request to the 3.10 branch. |
Thanks @shihai1991 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-99405 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit e02cc6d) Co-authored-by: Hai Shi <shihai1992@gmail.com> Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
(cherry picked from commit e02cc6d) Co-authored-by: Hai Shi <shihai1992@gmail.com> Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
https://bugs.python.org/issue36267