fix cPickle.c for 64-bit platforms (mainly Win64)

[tmick]

BPO	400526
Nosy	@gvanrossum
Files	None: None

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2000-06-28.22:24:20.000>
created_at = <Date 2000-06-07.03:49:50.000>
labels = []
title = 'fix cPickle.c for 64-bit platforms (mainly Win64)'
updated_at = <Date 2000-06-28.22:24:20.000>
user = 'https://bugs.python.org/tmick'

bugs.python.org fields:

activity = <Date 2000-06-28.22:24:20.000>
actor = 'gvanrossum'
assignee = 'gvanrossum'
closed = True
closed_date = None
closer = None
components = ['None']
creation = <Date 2000-06-07.03:49:50.000>
creator = 'tmick'
dependencies = []
files = ['2456']
hgrepos = []
issue_num = 400526
keywords = ['patch']
message_count = 6.0
messages = ['32793', '32794', '32795', '32796', '32797', '32798']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'tmick']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue400526'
versions = []

[tmick]

No description provided.

[tmick]

I confirm that, to the best of my knowledge and belief, this
contribution is free of any claims of third parties under
copyright, patent or other rights or interests ("claims"). To
the extent that I have any such claims, I hereby grant to CNRI a
nonexclusive, irrevocable, royalty-free, worldwide license to
reproduce, distribute, perform and/or display publicly, prepare
derivative versions, and otherwise use this contribution as part
of the Python software and its related documentation, or any
derivative versions thereof, at no cost to CNRI or its licensed
users, and to authorize others to do so.

I acknowledge that CNRI may, at its sole discretion, decide
whether or not to incorporate this contribution in the Python
software and its related documentation. I further grant CNRI
permission to use my name and other identifying information
provided to CNRI by me for use in connection with the Python
software and its related documentation.

[tmick]

This patch fixes cPickle.c for 64-bit platforms.

• The false assumption sizeof(long) == size(void*) exists where
  PyInt_FromLong is used to represent a pointer. The safe Python call for
  this is PyLong_FromVoidPtr. (On platforms where the above assumption *is*
  true a PyInt is returned as before so there is no effective change.)
• use size_t instead of int for some varaibles

[gvanrossum]

Should take this up with JimF?

[tmick]

Shall I approach Jim F(ulton?) with the patch? I can wave your name around like a big stick. :) Or maybe you have already done so.

[gvanrossum]

Jim can read it in the checkin messages like everyone else. :-)