-
-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just testing #32453
Comments
No description provided. |
didn't keep his finger on his nose |
does it stay? |
wish we could expunge the deleted ones |
closing this one again |
Testing. |
Reviewers: , Message: Here's the command line and output: And the help is: I like it :) Description: Please review this at http://codereview.appspot.com/25073 Affected files: Index: static/upload.py +fields = {'issue':'title', 'msg':'content', 'file':'description', } +def fetch(nodeid): @@ -453,6 +477,14 @@
group.add_option("--send_mail", action="store_true",
dest="send_mail", default=False,
help="Send notification email to reviewers.")
+# Link options
+group = parser.add_option_group("Link options")
+group.add_option("-R", "--roundup", action="store", dest="roundup",
+ metavar="ROUNDUP", default=None,
+ help="Python tracker issue number to link with.")
+group.add_option("-F", "--fetch_descr", action="store", dest="fetch_descr",
+ metavar="FETCHDESCR", default=None,
+ help="Tracker file or message to fetch description from.")
def GetRpcServer(options):
@@ -1291,7 +1323,10 @@
prompt = "Message describing this patch set: "
else:
prompt = "New issue subject: "
- message = options.message or raw_input(prompt).strip()
+ if options.roundup:
+ message = fetch(options.roundup)
+ else:
+ message = options.message or raw_input(prompt).strip()
if not message:
ErrorExit("A non-empty message is required")
rpc_server = GetRpcServer(options)
@@ -1307,11 +1342,16 @@
if "@" in reviewer and not reviewer.split("@")[1].count(".") == 1:
ErrorExit("Invalid email address: %s" % reviewer)
form_fields.append(("reviewers", options.reviewers))
+ tracker_email = 'report@bugs.python.org,'
if options.cc:
for cc in options.cc.split(','):
if "@" in cc and not cc.split("@")[1].count(".") == 1:
ErrorExit("Invalid email address: %s" % cc)
- form_fields.append(("cc", options.cc))
+ if options.roundup:
+ cc = tracker_email + options.cc
+ form_fields.append(("cc", cc))
+ elif options.roundup:
+ form_fields.append(("cc", tracker_email[:-1]))
description = options.description
if options.description_file:
if options.description:
@@ -1319,6 +1359,9 @@
file = open(options.description_file, 'r')
description = file.read()
file.close()
+ elif options.fetch_descr:
+ # XXX Add error handling as above
+ description = fetch(options.fetch_descr)
if description:
form_fields.append(("description", description))
# Send a hash of all the base file so the server can determine if a copy |
This is specific to the Python tracker, which Rietveld tries to avoid. PS. What do you mean by "wish we could expunge the deleted ones"? If |
Thanks for the feedback, Guido! gvanrossum wrote:
Yes, a wrapper is an option. MvL suggested a patch[1] and for this
Yes, you're missing the fact that you were the one saying "wish we upload.py fetched that from http://bugs.python.org/msg32813 because I [1] http://mail.python.org/pipermail/tracker-discuss/2009-March/001875.html |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: