Remove grammar rule from Makefile

[donnc]

BPO	403681
Nosy	@nascheme
Files	None: None

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2001-02-21.13:47:34.000>
created_at = <Date 2001-02-08.07:20:19.000>
labels = ['build']
title = 'Remove grammar rule from Makefile'
updated_at = <Date 2001-02-21.13:47:34.000>
user = 'https://bugs.python.org/donnc'

bugs.python.org fields:

activity = <Date 2001-02-21.13:47:34.000>
actor = 'nascheme'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Build']
creation = <Date 2001-02-08.07:20:19.000>
creator = 'donnc'
dependencies = []
files = ['3108']
hgrepos = []
issue_num = 403681
keywords = ['patch']
message_count = 4.0
messages = ['35647', '35648', '35649', '35650']
nosy_count = 2.0
nosy_names = ['nascheme', 'donnc']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue403681'
versions = []

[donnc]

When building from a distinct source directory, the build directory is naturally
empty, so make tries to build graminit.c and graminit.h and move them to their
natural location - the source directory. When the source directory is a read-only
filesystem that kills the build, and anyway it's inappropriate. There may be a
better way to express the rule, but previous releases seem to have mostly omitted
it anyway.

[nascheme]

I've checked in, IMHO, a better solution. The grammar
source files are now generated in the build directory. If
this doesn't work for a read-only source dir please let me
know.

[donnc]

Actually this is only a more complicated way to do the
same thing - now you generate the files, but you still
don't use them. Not graminit.h, anyway. Here's what
happens if I remove graminit.h from the source directory:

cc -c -g -O2 -Wall -Wstrict-prototypes -I.
-I/tulsa/src/python-2.1a2b/Include -DHAVE_CONFIG_H
-o Python/compile.o /tulsa/src/python-2.1a2b/Python/compile.c
/tulsa/src/python-2.1a2b/Python/compile.c:17: graminit.h: No such file or directory

You would have to add -IInclude to CFLAGS, along with
-I$(srcdir)/Include; otherwise --srcdir build with
modified grammar is broken (whether srcdir is read only
or read/write.)

[nascheme]

D'oh, your right. Can you look at patch bpo-103930? I don't
want to omit the rule. Prevous versions of Python did
omit it but that caused some surprises when people started
hacking on the grammar.