Ignore error making grammar src if srcdir is readonly

[nascheme]

BPO	403930
Nosy	@Yhg1s, @nascheme
Files	None: None

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/Yhg1s'
closed_at = <Date 2001-02-27.03:26:38.000>
created_at = <Date 2001-02-21.13:38:35.000>
labels = ['build']
title = 'Ignore error making grammar src if srcdir is readonly'
updated_at = <Date 2001-02-27.03:26:38.000>
user = 'https://github.com/nascheme'

bugs.python.org fields:

activity = <Date 2001-02-27.03:26:38.000>
actor = 'nascheme'
assignee = 'twouters'
closed = True
closed_date = None
closer = None
components = ['Build']
creation = <Date 2001-02-21.13:38:35.000>
creator = 'nascheme'
dependencies = []
files = ['3148']
hgrepos = []
issue_num = 403930
keywords = ['patch']
message_count = 4.0
messages = ['35802', '35803', '35804', '35805']
nosy_count = 2.0
nosy_names = ['twouters', 'nascheme']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue403930'
versions = []

[nascheme]

Does this make sense? My last change making graminit.h
and graminit.c in the build directory was wrong. The
compiler does not understand VPATH so the include
file could not be found. The new idea is to continue the
build even if the grammar sources cannot be regenerated
(maybe the source directory is readonly). I don't want
to remove the target completely since someone may change
the grammar and forget to generate the source.

[Yhg1s]

This doesn't look like it does what it is supposed to. At least, after applying the patch, Grammar doesn't get rebuilt at all, even when graminit.h is missing:

gcc -D_HAVE_BSDI -c -g -O2 -Wall -Wstrict-prototypes -I. -I../Include -DHAVE_CONFIG_H -o Python/compile.o ../Python/compile.c
../Python/compile.c:17: graminit.h: No such file or directory

I can't seem to get it to make it, even though there is a $(GRAMINIT_H) dependancy. 'make Include/graminit.h' no longer works, and neither does anything else I can come up with.

But I'd like to note I'm still against rebuilding the Grammar automatically in releases :-) I'm not really sure if it's still worth rebuilding the Grammar each time, myself. It was when I did the original (horribly broken) patch, but that was in the heat of 2.0, with lots of Grammar-changing patch-proposals about.

[nascheme]

"If make doesn't do what you expect it to, it's a good
chance the makefile is wrong." -- BSD Make manual

Some dependances were missing. Can you give the current
patch a whirl? BTW, why to you think rebuilding the
grammar source is a bad idea?

[nascheme]

Logged In: YES
user_id=35752

Applied. The old behavor was much too broken to leave
for the beta.