Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to specify a 'verify' script #35248

Closed
jnelson mannequin opened this issue Sep 28, 2001 · 2 comments
Closed

ability to specify a 'verify' script #35248

jnelson mannequin opened this issue Sep 28, 2001 · 2 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@jnelson
Copy link
Mannequin

jnelson mannequin commented Sep 28, 2001

BPO 466200
Nosy @akuchling

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/akuchling'
closed_at = <Date 2002-11-06.18:47:11.000>
created_at = <Date 2001-09-28.21:05:15.000>
labels = ['type-feature', 'library']
title = "ability to specify a 'verify' script"
updated_at = <Date 2002-11-06.18:47:11.000>
user = 'https://bugs.python.org/jnelson'

bugs.python.org fields:

activity = <Date 2002-11-06.18:47:11.000>
actor = 'niemeyer'
assignee = 'akuchling'
closed = True
closed_date = None
closer = None
components = ['Distutils']
creation = <Date 2001-09-28.21:05:15.000>
creator = 'jnelson'
dependencies = []
files = []
hgrepos = []
issue_num = 466200
keywords = []
message_count = 2.0
messages = ['6753', '6754']
nosy_count = 3.0
nosy_names = ['akuchling', 'jnelson', 'niemeyer']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue466200'
versions = []

@jnelson
Copy link
Mannequin Author

jnelson mannequin commented Sep 28, 2001

The following patch adds the ability to specify a
'verify' script (as used by the %verify).

Treatment is exactly the same as with post_install,
etc...

--- bdist_rpm.py        Wed Sep 12 11:42:17 2001
+++ /home/agamemnon/jnelson/bdist_rpm.py        Fri Sep
28 16:09:18 2001
@@ -131,6 +131,7 @@
         self.post_install = None
         self.pre_uninstall = None
         self.post_uninstall = None
+        self.verifyscript = None
         self.prep = None
         self.provides = None
         self.requires = None
@@ -210,6 +211,7 @@
         self.ensure_filename('post_install')
         self.ensure_filename('pre_uninstall')
         self.ensure_filename('post_uninstall')
+        self.ensure_filename('verifyscript')
 
         # XXX don't forget we punted on summaries and
descriptions -- they
         # should be handled here eventually!
@@ -423,6 +425,7 @@
             ('post', 'post_install', None),
             ('preun', 'pre_uninstall', None),
             ('postun', 'post_uninstall', None),
+            ('verify', 'verifyscript', None),
         ]
 
         for (rpm_opt, attr, default) in
script_options:

@jnelson jnelson mannequin closed this as completed Sep 28, 2001
@jnelson jnelson mannequin assigned akuchling Sep 28, 2001
@jnelson jnelson mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Sep 28, 2001
@jnelson jnelson mannequin closed this as completed Sep 28, 2001
@jnelson jnelson mannequin assigned akuchling Sep 28, 2001
@niemeyer
Copy link
Mannequin

niemeyer mannequin commented Nov 6, 2002

Logged In: YES
user_id=7887

Applied in the following CVS revisions:

Lib/distutils/command/bdist_rpm.py: 1.33->1.34
Misc/NEWS: 1.513->1.514

I've done a few changes to your original patch:

  • Named the option verify_script, for conformance with other options
    (clean_script, etc).

  • The rpm section is named "%verifyscript", not "%verify". I've reflected
    that in the script_options tuple.

Thank you!

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant