-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode fix for test in tkFileDialog.py #36382
Comments
Patch is against current CVS form 20020404. Python's open() uses the Py_FileSystemDefaultEncoding. Traceback (most recent call last):
File "tkFileDialog.py", line 105, in ?
print "open", askopenfilename(filetypes=[("all
filez", "*")])
UnicodeError: ASCII encoding error: ordinal not in
range(128) open() will work with the string directly now. (It might be interesting to drop a note about this in If you comment out the setlocale() you can see that 4.4.2002 |
Logged In: YES I think this patch is not acceptable. If the application People question the validity of using CODESET in the file |
Logged In: YES I agree with your analysis that the appplication has This is why we fixed the _test_ code to demonstrate exactly Our code also demonstrates that there might be a difference |
Logged In: YES Sorry, I misinterpreted your patch first. I agree with your distinction of a file system encoding, and As for the flaw in Tk: it turns out that Tcl has a different It is a good thing that Tkinter manages to represent file Committed as tkFileDialog.py 1.7. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: