Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose _Py_ReleaseInternedStrings #36703

Closed
warsaw opened this issue Jun 6, 2002 · 8 comments
Closed

Expose _Py_ReleaseInternedStrings #36703

warsaw opened this issue Jun 6, 2002 · 8 comments
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@warsaw
Copy link
Member

warsaw commented Jun 6, 2002

BPO 565378
Nosy @gvanrossum, @loewis, @warsaw
Files
  • release.txt
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/warsaw'
    closed_at = <Date 2002-07-12.17:36:33.000>
    created_at = <Date 2002-06-06.15:45:52.000>
    labels = ['interpreter-core']
    title = 'Expose _Py_ReleaseInternedStrings'
    updated_at = <Date 2002-07-12.17:36:33.000>
    user = 'https://github.com/warsaw'

    bugs.python.org fields:

    activity = <Date 2002-07-12.17:36:33.000>
    actor = 'barry'
    assignee = 'barry'
    closed = True
    closed_date = None
    closer = None
    components = ['Interpreter Core']
    creation = <Date 2002-06-06.15:45:52.000>
    creator = 'barry'
    dependencies = []
    files = ['4321']
    hgrepos = []
    issue_num = 565378
    keywords = ['patch']
    message_count = 8.0
    messages = ['40228', '40229', '40230', '40231', '40232', '40233', '40234', '40235']
    nosy_count = 3.0
    nosy_names = ['gvanrossum', 'loewis', 'barry']
    pr_nums = []
    priority = 'normal'
    resolution = 'rejected'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue565378'
    versions = ['Python 2.3']

    @warsaw
    Copy link
    Member Author

    warsaw commented Jun 6, 2002

    An implementation of the idea expressed here:

    http://mail.python.org/pipermail/python-dev/2002-June/025067.html

    This exposes the clearing of the intern dictionary to
    Python via gc.release_interns(). Patch includes doc
    updates and a test case.

    @warsaw warsaw closed this as completed Jun 6, 2002
    @warsaw warsaw self-assigned this Jun 6, 2002
    @warsaw warsaw added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jun 6, 2002
    @warsaw warsaw closed this as completed Jun 6, 2002
    @warsaw warsaw self-assigned this Jun 6, 2002
    @warsaw warsaw added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jun 6, 2002
    @gvanrossum
    Copy link
    Member

    Logged In: YES
    user_id=6380

    Um, that's totally unsafe. See
    http://mail.python.org/pipermail/python-dev/2002-June/025071.html

    @warsaw
    Copy link
    Member Author

    warsaw commented Jun 6, 2002

    Logged In: YES
    user_id=12800

    Yes, I know why this isn't right. Notes:

    • we probably want to incref the string pointed to by
      ob_intern so that the reference is counted in the interned
      string's refcount

    • when the referent is freed, we'll need to decref the ob_intern

    this addresses

    http://mail.python.org/pipermail/python-dev/2002-June/025071.html

    @warsaw
    Copy link
    Member Author

    warsaw commented Jun 6, 2002

    Logged In: YES
    user_id=12800

    Guido also suggests to move this sys instead of gc (although
    gc isn't totally out of the question). Maybe Neil has an
    opinion one way or the other?

    @gvanrossum
    Copy link
    Member

    Logged In: YES
    user_id=6380

    Barry, are you going to do an implementation of what we
    decided on? If not, maybe unassign this and let someone else
    submit one.

    @warsaw
    Copy link
    Member Author

    warsaw commented Jun 7, 2002

    Logged In: YES
    user_id=12800

    I'm planning to, yes. I may not get to it until early next
    week though, so if someone is motivated to do it before
    then, let me know (or steal the assignment).

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jun 8, 2002

    Logged In: YES
    user_id=21627

    Could not this get exposed as str.some_static_method?

    @warsaw
    Copy link
    Member Author

    warsaw commented Jul 12, 2002

    Logged In: YES
    user_id=12800

    I'm closing this as rejected since others have more time and
    energy to do this (i.e. murder intern strings :) right.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants