Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Galeon support to webbrowser.py #36922

Closed
oracle mannequin opened this issue Jul 24, 2002 · 9 comments
Closed

Adds Galeon support to webbrowser.py #36922

oracle mannequin opened this issue Jul 24, 2002 · 9 comments
Labels
stdlib Python modules in the Lib dir

Comments

@oracle
Copy link
Mannequin

oracle mannequin commented Jul 24, 2002

BPO 585913
Nosy @loewis
Files
  • webbrowser.py.patch: Context Diff Patch
  • web.diff: patch Rename README to README.rst and enhance formatting #2, little cleanups
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2002-10-10.22:50:58.000>
    created_at = <Date 2002-07-24.13:27:49.000>
    labels = ['library']
    title = 'Adds Galeon support to webbrowser.py'
    updated_at = <Date 2002-10-10.22:50:58.000>
    user = 'https://bugs.python.org/oracle'

    bugs.python.org fields:

    activity = <Date 2002-10-10.22:50:58.000>
    actor = 'nnorwitz'
    assignee = 'nnorwitz'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2002-07-24.13:27:49.000>
    creator = 'oracle'
    dependencies = []
    files = ['4443', '4444']
    hgrepos = []
    issue_num = 585913
    keywords = ['patch']
    message_count = 9.0
    messages = ['40629', '40630', '40631', '40632', '40633', '40634', '40635', '40636', '40637']
    nosy_count = 3.0
    nosy_names = ['loewis', 'nnorwitz', 'oracle']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue585913'
    versions = ['Python 2.3']

    @oracle
    Copy link
    Mannequin Author

    oracle mannequin commented Jul 24, 2002

    Simple context diff against current CVS tree to add
    support for Galeon to webbrowser.py

    @oracle oracle mannequin closed this as completed Jul 24, 2002
    @oracle oracle mannequin assigned nnorwitz Jul 24, 2002
    @oracle oracle mannequin added the stdlib Python modules in the Lib dir label Jul 24, 2002
    @oracle oracle mannequin closed this as completed Jul 24, 2002
    @oracle oracle mannequin assigned nnorwitz Jul 24, 2002
    @oracle oracle mannequin added the stdlib Python modules in the Lib dir label Jul 24, 2002
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jul 26, 2002

    Logged In: YES
    user_id=21627

    How does this relate to

    https://sourceforge.net/tracker/index.php?func=detail&aid=586437&group_id=5470&atid=305470

    ?

    @oracle
    Copy link
    Mannequin Author

    oracle mannequin commented Jul 26, 2002

    Logged In: YES
    user_id=40173

    Not really sure. I assume it's just a second patch by
    another author.

    What can I say, day late and a dollar short. ;)

    Having looked at the other patch, it appears mine is a
    little more well rounded/complete/feature rich, if only
    slightly. I invite you to take a look for your self. I'm
    also not sure what version of webbrowser.py the other patch
    is against. My patch is against the CVS version so it will
    be a breeze to apply.

    Enjoy!

    @oracle
    Copy link
    Mannequin Author

    oracle mannequin commented Aug 12, 2002

    Logged In: YES
    user_id=40173

    Has then patch been accepted? What's the standard why of
    letting people know if a patch has been accepted or rejected?

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Aug 12, 2002

    Logged In: YES
    user_id=21627

    If the patch has been accepted, its Resolution will be set
    to accepted, and SF will send you a message - so no, it
    hasn't been accepted yet.

    I still haven't found the time to compare the two patches,
    and nobody else has presented any clear analysis of the
    relative qualities, so I still don't know which one to
    accept - apparently, nobody else has looked at them, either.

    @nnorwitz
    Copy link
    Mannequin

    nnorwitz mannequin commented Oct 9, 2002

    Logged In: YES
    user_id=33168

    Martin, I've closed the other (duplicate) patch. I've
    attached a new patch here with a few cleanups. I manually
    tested that this works with galeon.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Oct 10, 2002

    Logged In: YES
    user_id=21627

    Neal, thanks for testing it. This is all this patch has been
    waiting for, so please apply it.

    @oracle
    Copy link
    Mannequin Author

    oracle mannequin commented Oct 10, 2002

    Logged In: YES
    user_id=40173

    Ya thanks for cleaning it up. After I submitted the patch,
    I realized that I had left some print statements hanging around.

    @nnorwitz
    Copy link
    Mannequin

    nnorwitz mannequin commented Oct 10, 2002

    Logged In: YES
    user_id=33168

    Checked in as Lib/webbrowser.py 1.33

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants