Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib.splituser(): '@' in usrname #37051

Closed
slyphon mannequin opened this issue Aug 17, 2002 · 3 comments
Closed

urllib.splituser(): '@' in usrname #37051

slyphon mannequin opened this issue Aug 17, 2002 · 3 comments
Assignees
Labels
extension-modules C modules in the Modules dir

Comments

@slyphon
Copy link
Mannequin

slyphon mannequin commented Aug 17, 2002

BPO 596581
Nosy @gvanrossum, @rhettinger
Files
  • urllib.patch: a patch for urllib.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/rhettinger'
    closed_at = <Date 2002-08-20.19:52:14.000>
    created_at = <Date 2002-08-17.21:55:10.000>
    labels = ['extension-modules']
    title = "urllib.splituser(): '@' in usrname"
    updated_at = <Date 2002-08-20.19:52:14.000>
    user = 'https://bugs.python.org/slyphon'

    bugs.python.org fields:

    activity = <Date 2002-08-20.19:52:14.000>
    actor = 'gvanrossum'
    assignee = 'rhettinger'
    closed = True
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2002-08-17.21:55:10.000>
    creator = 'slyphon'
    dependencies = []
    files = ['4519']
    hgrepos = []
    issue_num = 596581
    keywords = ['patch']
    message_count = 3.0
    messages = ['40962', '40963', '40964']
    nosy_count = 3.0
    nosy_names = ['gvanrossum', 'rhettinger', 'slyphon']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue596581'
    versions = ['Python 2.3']

    @slyphon
    Copy link
    Mannequin Author

    slyphon mannequin commented Aug 17, 2002

    This was in response to "[ 581529 ] bug in
    splituser(host) in urllib". This was a one-line
    change. The issue was that if a username contained
    the '@' symbol, the urllib.splituser(host) method
    wouldn't return the correct information.

    if you were to try
    urllib.splituser(Jones@CrunchyFrog.net@Whizzo.com),
    you'd get ['Jones', 'CrunchyFrog.net@Whizzo.com']

    after applying this patch, you get
    ['Jones@CrunchyFrog.net', 'Whizzo.com']

    So, there you are... :-)

    @slyphon slyphon mannequin closed this as completed Aug 17, 2002
    @slyphon slyphon mannequin assigned rhettinger Aug 17, 2002
    @slyphon slyphon mannequin added the extension-modules C modules in the Modules dir label Aug 17, 2002
    @slyphon slyphon mannequin closed this as completed Aug 17, 2002
    @slyphon slyphon mannequin assigned rhettinger Aug 17, 2002
    @slyphon slyphon mannequin added the extension-modules C modules in the Modules dir label Aug 17, 2002
    @rhettinger
    Copy link
    Contributor

    Logged In: YES
    user_id=80475

    Applied as urllib.py 1.150 and 1.135.6.4
    Closing patch and related bug.

    @gvanrossum
    Copy link
    Member

    Logged In: YES
    user_id=6380

    Fine, but I'm baffled that someone would try this. RFC1738 says:

    "Within the user and password field, any ":", "@", or "/"
    must be encoded."

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants