No __mod__ on str subclass

[nascheme]

BPO	615506
Nosy	@gvanrossum, @nascheme
Files	str_mod.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/nascheme'
closed_at = <Date 2002-11-17.20:34:00.000>
created_at = <Date 2002-09-27.14:35:28.000>
labels = ['interpreter-core']
title = 'No __mod__ on str subclass'
updated_at = <Date 2002-11-17.20:34:00.000>
user = 'https://github.com/nascheme'

bugs.python.org fields:

activity = <Date 2002-11-17.20:34:00.000>
actor = 'gvanrossum'
assignee = 'nascheme'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2002-09-27.14:35:28.000>
creator = 'nascheme'
dependencies = []
files = ['624']
hgrepos = []
issue_num = 615506
keywords = []
message_count = 3.0
messages = ['12520', '12521', '12522']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'nascheme']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue615506'
versions = []

[nascheme]

PyNumber_Remainder does not use __mod__ on str and unicode
subclasses. I guess the fix would be to check for
nb_remainder first
and then fallback to PyString_Format or PyUnicode_Format.

[nascheme]

Logged In: YES
user_id=35752

The attached patch adds __mod__ to the 'str' and 'unicode'
types. The side effect of this is that PyNumber_Check returns
true for these types. This is not a huge loss since
PyNumber_Check is already pretty useless. selectmodule.c
was affected by this and was fixed by improving the error
message returned by PyFloat_AsDouble (matching what
PyInt_AsLong does) and using it to convert the timeout
argument to a float.

[gvanrossum]

Logged In: YES
user_id=6380

Looks good to me.