autoconf-2.5X tweaks for configure.in

[ahaas]

BPO	623771
Nosy	@loewis
Files	py_config.diff: diff/patch file py_ac_init.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/loewis'
closed_at = <Date 2002-10-26.13:49:11.000>
created_at = <Date 2002-10-15.21:30:36.000>
labels = ['build']
title = 'autoconf-2.5X tweaks for configure.in'
updated_at = <Date 2002-10-26.13:49:11.000>
user = 'https://bugs.python.org/ahaas'

bugs.python.org fields:

activity = <Date 2002-10-26.13:49:11.000>
actor = 'loewis'
assignee = 'loewis'
closed = True
closed_date = None
closer = None
components = ['Build']
creation = <Date 2002-10-15.21:30:36.000>
creator = 'ahaas'
dependencies = []
files = ['4638', '4639']
hgrepos = []
issue_num = 623771
keywords = ['patch']
message_count = 6.0
messages = ['41382', '41383', '41384', '41385', '41386', '41387']
nosy_count = 2.0
nosy_names = ['loewis', 'ahaas']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue623771'
versions = ['Python 2.3']

[ahaas]

Hi.

Here's a small patch that adjust AC_INIT and AC_OUTPUT
from the autoconf-2.13 style to the new autoconf-2.5X
style. In changing these macros to their new format,
the addition of AC_CONFIG_SRCDIR and AC_CONFIG_FILES is
required. I've also removed the VERSION macro as that
value can be defined in the second argument of AC_INIT.

Art Haas
ahaas@neosoft.com

[loewis]

Logged In: YES
user_id=21627

It appears that you did not test this change. AC_INIT does
not define VERSION, but PACKAGE_VERSION.

Even if this is fixed (somehow), the resulting pyconfig.h
will be installed, and then conflict in its PACKAGE_VERSION
definition with other packages which also use autoconf. So
I'm not sure this should be done at all.

[ahaas]

Logged In: YES
user_id=629911

Hi.

I did test this, and it worked fine - as far as I could
tell. The autoconf docs I have (autoconf-2.54) show that
AC_INIT is defined like ...

AC_INIT (PACKAGE, VERSION, [BUG-REPORT], [TARNAME])

... and PACKAGE_VERSION is taken from VERSION. I suppose
that if there is a conflict, then the variable VERSION can
be directly defined after AC_INIT, and it can be specified
to whatever is needed to avoid the problems you see.

Still, the format for the AC_INIT macro as it exists now is
obsolete, so I believe it's better to change to the current
format. Changing AC_OUTPUT to the current style is also a
good move IMHO. There's another change I'd also suggest -
renaming configure.in to configure.ac, as autoconf now
suggests the ".ac" extension. That can be done later.

Art Haas

[loewis]

Logged In: YES
user_id=21627

Can you please verify the setting of VERSION in your
generate Makefile? When I use your patch, I get

VERSION=

whereas I should get

VERSION=	2.3

Also, can you please use autoconf 2.53? This is the version
that Python is currently is developed with, and we cannot
make use of strategies or features that are available in
2.54 only.

[ahaas]

Logged In: YES
user_id=629911

My Makefile has a blank VERSION also, so I see that the part
of the patch where I removed the VERSION variable is wrong.
I'm attaching a new patch for the AC_INIT bits of
configure.in. In this patch, there are a couple of variables
defined using m4_define(), and these are then used to
provide the version argument for AC_INIT and the value for
the VERSION variable. After rebuilding configure with this
patch, the variable VERSION in the Makefile is set to 2.3,
as it should be.

The AC_OUTPUT changes from the first patch are still good.

[loewis]

Logged In: YES
user_id=21627

I have committed something like this as

configure.in 1.360;
configure 1.349;

The version computation appeared to me overly complex, and
I've omitted the bug report address: the info documentation
says this should be an email address, not an URL.