Better inspect.BlockFinder fixes bug

[pobrien]

BPO	634557
Nosy	@rhettinger
Files	inspect.patch: diff -c patch for inspect.py from CVS

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2003-01-19.13:26:07.000>
created_at = <Date 2002-11-06.18:04:06.000>
labels = ['library']
title = 'Better inspect.BlockFinder fixes bug'
updated_at = <Date 2003-01-19.13:26:07.000>
user = 'https://bugs.python.org/pobrien'

bugs.python.org fields:

activity = <Date 2003-01-19.13:26:07.000>
actor = 'rhettinger'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2002-11-06.18:04:06.000>
creator = 'pobrien'
dependencies = []
files = ['4688']
hgrepos = []
issue_num = 634557
keywords = ['patch']
message_count = 4.0
messages = ['41581', '41582', '41583', '41584']
nosy_count = 3.0
nosy_names = ['nnorwitz', 'rhettinger', 'pobrien']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue634557'
versions = ['Python 2.2']

[pobrien]

inspect.BlockFinder didn't do a good enough job finding  
the end of code blocks. This can be observed by  
running:  
  
>>> import inspect  
>>> import tokenize  
>>> print inspect.getsource(tokenize.TokenError)  
class TokenError(Exception): pass  
  
class StopTokenizing(Exception): pass  
  
def printtoken(type, token, (srow, scol), (erow, ecol),  
line): # for testing  
    print "%d,%d-%d,%d:\t%s\t%s" % \  
        (srow, scol, erow, ecol, tok_name[type],  
repr(token))  
  
>>>   
  
Notice how it picks up extra source code lines. The  
attached patch fixes this problem. There should probably 
be some additional unit tests for this, but I ran out of time 
and energy.

[nnorwitz]

Logged In: YES
user_id=33168

Does this fix bug bpo-595018? There are a few other inspect
module bugs I think.

[pobrien]

Logged In: YES
user_id=179604

Yes, this does fix bug bpo-595018. I'll look at the other inspect
module bugs when I've got some spare time.

[rhettinger]

Logged In: YES
user_id=80475

I spent a little time testing this one and checked to make
sure it didn't clash with my fixes.

Marking as accepted and applying as Lib/inspect 1.41.