Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct non-blocking behavior in _ssl.c #37860

Closed
gtalvola mannequin opened this issue Jan 29, 2003 · 3 comments
Closed

correct non-blocking behavior in _ssl.c #37860

gtalvola mannequin opened this issue Jan 29, 2003 · 3 comments
Assignees
Labels
extension-modules C modules in the Modules dir

Comments

@gtalvola
Copy link
Mannequin

gtalvola mannequin commented Jan 29, 2003

BPO 676472
Nosy @gvanrossum
Files
  • _ssl.c.patch: patch to _ssl.c to fix non-blocking behavior
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
    closed_at = <Date 2003-01-31.18:18:50.000>
    created_at = <Date 2003-01-29.00:15:27.000>
    labels = ['extension-modules']
    title = 'correct non-blocking behavior in _ssl.c'
    updated_at = <Date 2003-01-31.18:18:50.000>
    user = 'https://bugs.python.org/gtalvola'

    bugs.python.org fields:

    activity = <Date 2003-01-31.18:18:50.000>
    actor = 'gvanrossum'
    assignee = 'gvanrossum'
    closed = True
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2003-01-29.00:15:27.000>
    creator = 'gtalvola'
    dependencies = []
    files = ['4967']
    hgrepos = []
    issue_num = 676472
    keywords = ['patch']
    message_count = 3.0
    messages = ['42565', '42566', '42567']
    nosy_count = 2.0
    nosy_names = ['gvanrossum', 'gtalvola']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue676472'
    versions = ['Python 2.3']

    @gtalvola
    Copy link
    Mannequin Author

    gtalvola mannequin commented Jan 29, 2003

    This is yet another patch to _ssl.c that sets the
    underlying BIO to non-blocking if the socket being
    wrapped is non-blocking. It also correctly loops when
    SSL_connect, SSL_write, or SSL_read indicates that it
    needs to read or write more bytes.

    This seems to fix bug bpo-673797 which was not fixed by my
    previous patch.

    I'm waiting for Ben Laurie to review this patch for me,
    then I'll assign it to Guido to check it in.

    @gtalvola gtalvola mannequin closed this as completed Jan 29, 2003
    @gtalvola gtalvola mannequin assigned gvanrossum Jan 29, 2003
    @gtalvola gtalvola mannequin added the extension-modules C modules in the Modules dir label Jan 29, 2003
    @gtalvola gtalvola mannequin closed this as completed Jan 29, 2003
    @gtalvola gtalvola mannequin assigned gvanrossum Jan 29, 2003
    @gtalvola gtalvola mannequin added the extension-modules C modules in the Modules dir label Jan 29, 2003
    @gtalvola
    Copy link
    Mannequin Author

    gtalvola mannequin commented Jan 31, 2003

    Logged In: YES
    user_id=88162

    Reviewed by Ben Laurie, ready to check in.

    @gvanrossum
    Copy link
    Member

    Logged In: YES
    user_id=6380

    OK, checked in as _ssl.c 1.10. Thanks to both of you!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant