OpenVMS complementary patches

[pieronne]

BPO	708495
Nosy	@loewis
Files	diff: Correct formatted diff file

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/loewis'
closed_at = <Date 2003-05-03.09:15:28.000>
created_at = <Date 2003-03-23.20:01:46.000>
labels = ['interpreter-core']
title = 'OpenVMS complementary patches'
updated_at = <Date 2003-05-03.09:15:28.000>
user = 'https://bugs.python.org/pieronne'

bugs.python.org fields:

activity = <Date 2003-05-03.09:15:28.000>
actor = 'loewis'
assignee = 'loewis'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2003-03-23.20:01:46.000>
creator = 'pieronne'
dependencies = []
files = ['5121']
hgrepos = []
issue_num = 708495
keywords = ['patch']
message_count = 4.0
messages = ['43139', '43140', '43141', '43142']
nosy_count = 2.0
nosy_names = ['loewis', 'pieronne']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue708495'
versions = ['Python 2.3']

[pieronne]

Explanations of the various patches:

fcntlmodule.c
Under VMS the third argument is declared as void *

expat.h
VMS C compiler can optionally mangle name longer
than 31 characters, so it not necessary to change
long name

fileobject.c
As the comment indicate this solve a problem into
test_fileinput, but I don't understand why...

fpectlmodule.c
Enable SIGFPE handler

import.c
Support of VMS filesystem ODS-5

mmapmodule.c
VMS need a fsync before a call to fstat to return
accurate information

myreadline.c
Use of vms__StdioReadline

posixmodule.c
I have move some initialisation part to a specific VMS
file, so I have remove it form posixmodule.c

pyexpat.c
Convert VMS filename to a UNIX style filename.

socketmodule.c
This patch is the only one which is not delimited by
#ifdef __VMS
#endif
because IMHO it fix a bug into the original code

socketmodule.h
need to include socket.h and not sys/socket.h

sysmodule.c
Convert VMS filename to a UNIX style filename.

Regards,

Jean-François

[loewis]

Logged In: YES
user_id=21627

Can you please combine the patches into a single patch,
which can be applied using

patch -p0

??? You can use "diff -ur" or "cvs diff" to create a
recursive patch.

[loewis]

Logged In: YES
user_id=21627

Can you please explain the expat.h change? This is an
imported source, so I don't want to modify it unless there
is a really good reason.

The fileobject.c modification needs better analysis.
"corrects a test case problem" is not enough reason to make
such a change. Does the test case make assumptions that are
not supported by the relevant standards? Is there a bug in
VMS? etc.

[loewis]

Logged In: YES
user_id=21627

Thanks for the patch. Applied as

bz2module.c 1.19
fcntlmodule.c 2.39
fpectlmodule.c 2.19
grpmodule.c 2.21
mmapmodule.c 2.45
posixmodule.c 2.299
socketmodule.c 1.263
socketmodule.h 1.9
myreadline.c 2.29
dynload_shlib.c 2.15
sysmodule.c 2.118