Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix 548176: urlparse('http://foo?blah') errs #38242

Closed
staschuk mannequin opened this issue Mar 30, 2003 · 3 comments
Closed

Bug fix 548176: urlparse('http://foo?blah') errs #38242

staschuk mannequin opened this issue Mar 30, 2003 · 3 comments
Labels
stdlib Python modules in the Lib dir

Comments

@staschuk
Copy link
Mannequin

staschuk mannequin commented Mar 30, 2003

BPO 712317
Files
  • urlparse-netloc-end-at-qmark.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2005-01-09.15:32:47.000>
    created_at = <Date 2003-03-30.20:16:56.000>
    labels = ['library']
    title = "Bug fix 548176: urlparse('http://foo?blah') errs"
    updated_at = <Date 2005-01-09.15:32:47.000>
    user = 'https://bugs.python.org/staschuk'

    bugs.python.org fields:

    activity = <Date 2005-01-09.15:32:47.000>
    actor = 'jlgijsbers'
    assignee = 'jlgijsbers'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2003-03-30.20:16:56.000>
    creator = 'staschuk'
    dependencies = []
    files = ['5145']
    hgrepos = []
    issue_num = 712317
    keywords = ['patch']
    message_count = 3.0
    messages = ['43240', '43241', '43242']
    nosy_count = 3.0
    nosy_names = ['jlgijsbers', 'staschuk', 'mrovner']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue712317'
    versions = ['Python 2.3']

    @staschuk
    Copy link
    Mannequin Author

    staschuk mannequin commented Mar 30, 2003

    For detailed description of the problem, see
    http://www.python.org/sf/548176
    In summary, URLs such as
    http://www.example.com?query=spam
    are misparsed by urlparse.urlparse, which decides that
    everything after the '//' is the host name. This is contrary to
    RFC 2396 and probably contrary to the intent of RFC 1738.

    The patch corrects the problem, adds a test to expose it,
    and rearranges some of the tests to better exercise the
    code in question.

    @staschuk staschuk mannequin closed this as completed Mar 30, 2003
    @staschuk staschuk mannequin assigned jlgijsbers Mar 30, 2003
    @staschuk staschuk mannequin added the stdlib Python modules in the Lib dir label Mar 30, 2003
    @staschuk staschuk mannequin closed this as completed Mar 30, 2003
    @staschuk staschuk mannequin assigned jlgijsbers Mar 30, 2003
    @staschuk staschuk mannequin added the stdlib Python modules in the Lib dir label Mar 30, 2003
    @mrovner
    Copy link
    Mannequin

    mrovner mannequin commented Jan 27, 2004

    Logged In: YES
    user_id=162094

    -1. See my comment at http://www.python.org/sf/548176

    @jlgijsbers
    Copy link
    Mannequin

    jlgijsbers mannequin commented Jan 9, 2005

    Logged In: YES
    user_id=469548

    See bug bpo-548176 for why this patch is okay anyway. Checked
    in on maint24 and HEAD.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants