test_timeout updates

[hdima]

BPO	728815
Nosy	@loewis, @doerwalter, @rhettinger
Superseder	bpo-1677694: test_timeout refactoring
Files	test_timeout.diff: Lib/test/test_timeout.py patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-07-17.02:34:31.315>
created_at = <Date 2003-04-28.10:21:58.000>
labels = ['tests']
title = 'test_timeout updates'
updated_at = <Date 2010-07-17.02:34:31.315>
user = 'https://bugs.python.org/hdima'

bugs.python.org fields:

activity = <Date 2010-07-17.02:34:31.315>
actor = 'belopolsky'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2003-04-28.10:21:58.000>
creator = 'hdima'
dependencies = []
files = ['5221']
hgrepos = []
issue_num = 728815
keywords = ['patch']
message_count = 9.0
messages = ['43513', '43514', '43515', '43516', '43517', '43518', '43519', '43520', '43521']
nosy_count = 6.0
nosy_names = ['loewis', 'doerwalter', 'collinwinter', 'rhettinger', 'hdima', 'sonderblade']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = '1677694'
type = None
url = 'https://bugs.python.org/issue728815'
versions = ['Python 2.5']

[hdima]

Changes:

• code refactoring;
• now we catch only exceptions with proper errno codes
  (also see bug bpo-708927);
• addr_remote changed, ('www.google.com', 80) not
  always works for me since we use transparent proxy;
• attempt to implement testSend(), testSendto(),
  testSendall();

[rhettinger]

Logged In: YES
user_id=80475

Walter, are you interested in working this patch?

[doerwalter]

Logged In: YES
user_id=89016

I'm no expert in socket programming, so the final decision
whether this is OK is your's.

[rhettinger]

Logged In: YES
user_id=80475

I'll give it more review.

Since Py2.3b2 is out, I'm marking this as a change for Py2.4
and we can apply it in early August.

[rhettinger]

Logged In: YES
user_id=80475

I'll give it more review.

Since Py2.3b2 is out, I'm marking this as a change for Py2.4
and we can apply it in early August.

[rhettinger]

Logged In: YES
user_id=80475

I'll give it more review.

Since Py2.3b2 is out, I'm marking this as a change for Py2.4
and we can apply it in early August.

[loewis]

Logged In: YES
user_id=21627

rhettinger: would you like to review it now? If not, please
unassign.

[sonderblade]

I have created a patch that I hope can supersede this one. This patch
does some nice refactorings to test_timeout.py by encapsulating some
common code in a sockOperation method. Then that method is used to run
the function under test. It also implements tests for testSend,
testSendto and testSendall. Plus, (I think) it fixes a bug which (I
think) only happens when you access the internet from behind a web
proxy.

I think the patch is good but there were two problems with it so I
created a new one. First, it tries to filter out errors dealing with
timeouts from normal socket.error's. But the author forgot about args
with only one string as a value. Second, I do not like how the actual
assertion of the test is done in the tearDown method.

My patch fixes those problems, otherwise it is mostly identical to
this patch. It is bpo-1677694 at http://sourceforge.net/tracker/index.php?func=detail&aid=1677694&group_id=5470&atid=105470

[collinwinter]

Bjorn's patch bpo-1677694 supersedes this one, closing.