markupbase parse_declaration cannot recognize comments

[jimjjewett]

BPO	736659
Nosy	@freddrake

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/freddrake'
closed_at = <Date 2005-08-23.04:09:11.000>
created_at = <Date 2003-05-12.20:34:28.000>
labels = ['library']
title = 'markupbase parse_declaration cannot recognize comments'
updated_at = <Date 2005-08-23.04:09:11.000>
user = 'https://bugs.python.org/jimjjewett'

bugs.python.org fields:

activity = <Date 2005-08-23.04:09:11.000>
actor = 'fdrake'
assignee = 'fdrake'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2003-05-12.20:34:28.000>
creator = 'jimjjewett'
dependencies = []
files = []
hgrepos = []
issue_num = 736659
keywords = []
message_count = 3.0
messages = ['15982', '15983', '15984']
nosy_count = 2.0
nosy_names = ['fdrake', 'jimjjewett']
pr_nums = []
priority = 'low'
resolution = 'wont fix'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue736659'
versions = []

[jimjjewett]

In markupbase class parser method parse_declaration

It verfies that the first two characters are "<!"

Then it returns -1 if the next character is "-".

After that, it checks to see if the next two characters
are "--", but if they were, it would already have returned.

Solution: Check for comments before checking for a
short buffer.

        if rawdata[j:j+1] == '--': #comment
            # Locate --.*-- as the body of the comment
            return self.parse_comment(i)
        if rawdata[j:j+1] in ("-", ""):
            # Start of comment followed by buffer 
            # boundary, or just a buffer boundary.
            return -1

[freddrake]

Logged In: YES
user_id=3066

As noted in the related patch (bpo-901369), this probably
shouldn't be considered a bug. Keeping this open pending
outcome of email discussion with OP.

[freddrake]

Logged In: YES
user_id=3066

Closed by docstring change in Lib/markupbase.py revisions
1.11, 1.10.4.1.