SimpleHTTPServer directory-indexing "bug" fix

[solomoriah]

BPO	827559
Nosy	@loewis, @akuchling
Files	SimpleHTTPServer.py.patch: See body.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/akuchling'
closed_at = <Date 2006-12-22.19:09:06.000>
created_at = <Date 2003-10-21.14:49:46.000>
labels = ['library']
title = 'SimpleHTTPServer directory-indexing "bug" fix'
updated_at = <Date 2006-12-22.19:09:06.000>
user = 'https://bugs.python.org/solomoriah'

bugs.python.org fields:

activity = <Date 2006-12-22.19:09:06.000>
actor = 'akuchling'
assignee = 'akuchling'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2003-10-21.14:49:46.000>
creator = 'solomoriah'
dependencies = []
files = ['5651']
hgrepos = []
issue_num = 827559
keywords = ['patch']
message_count = 5.0
messages = ['44813', '44814', '44815', '44816', '44817']
nosy_count = 4.0
nosy_names = ['loewis', 'akuchling', 'solomoriah', 'titus']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue827559'
versions = ['Python 2.5']

[solomoriah]

The SimpleHTTPServer.py module, when presented with a
URL of the form:

  http://some.site.com/directory

should redirect the browser to:

  http://some.site.com/directory/

This is evidently a standard behavior of major
webservers (Apache and IIS at least). SimpleHTTPServer
does not do this, but fortunately it is simple to
implement (patch attached, naturally).

I am providing a fix for 2.2 but this problem appears
to be in earlier versions, and is also in 2.3. This
patch appears to work fine for 2.3.

[loewis]

Logged In: YES
user_id=21627

Why is this a bug? SimpleHTTPServer already returns the
directory content if only the directory name is given, with
or without trailing slash. I believe Apache does that only
as an implementation detail, and it is unfortunate that this
detail is exposed to clients.

So unless you can report a specific problem with the
approach taken by SimpleHTTPServer, I'm tempted to reject
this patch.

[solomoriah]

Logged In: YES
user_id=321948

Oops. Allow me to clarify. Directory names without a
trailing slash need to be redirected to the same name with
the trailing slash to avoid breaking relative links from the
page.

I use SimpleHTTPServer to test websites which will be
deployed via Apache. Relative links on default directory
pages (index.html) are broken using SimpleHTTPServer but
work correctly on Apache.

This is a de facto standard at least (I haven't read the
RFC's but both IE and Mozilla expect this behavior).

[titus]

Logged In: YES
user_id=23486

Clearly a bug, IMO: a reference to a directory name w/o a slash
will return the directory listing, but relative links do not then work.
(Does this need more explication or ???)

Patch works against latest CVS & fixes behavior. Recommend
application.

[akuchling]

Committed to the trunk in rev. 53147 and to 25-maint in rev. 53148. Thanks for the fix!