Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httplib hardcodes Accept-Encoding #39467

Closed
calvin mannequin opened this issue Oct 28, 2003 · 5 comments
Closed

httplib hardcodes Accept-Encoding #39467

calvin mannequin opened this issue Oct 28, 2003 · 5 comments
Labels
stdlib Python modules in the Lib dir

Comments

@calvin
Copy link
Mannequin

calvin mannequin commented Oct 28, 2003

BPO 831747
Nosy @loewis
Files
  • httplib_skip_headers.diff: add skip_accept_encoding to HttpConnection.putrequest
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2003-11-19.19:52:23.000>
    created_at = <Date 2003-10-28.13:38:13.000>
    labels = ['library']
    title = 'httplib hardcodes Accept-Encoding'
    updated_at = <Date 2003-11-19.19:52:23.000>
    user = 'https://bugs.python.org/calvin'

    bugs.python.org fields:

    activity = <Date 2003-11-19.19:52:23.000>
    actor = 'loewis'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2003-10-28.13:38:13.000>
    creator = 'calvin'
    dependencies = []
    files = ['1084']
    hgrepos = []
    issue_num = 831747
    keywords = []
    message_count = 5.0
    messages = ['18783', '18784', '18785', '18786', '18787']
    nosy_count = 2.0
    nosy_names = ['loewis', 'calvin']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue831747'
    versions = []

    @calvin
    Copy link
    Mannequin Author

    calvin mannequin commented Oct 28, 2003

    in httplib.py the request() method adds a hardcoded
    Accept-Encoding header with the 'identity' value.
    This should at least be optional, since I have several
    programs supporting encodings like 'gzip' or 'deflate'
    and I want to be able to specify my own Accept-Encoding
    header.

    I suggest adding (similar to skip_host) a
    skip_accept_encoding optional argument.

    @calvin calvin mannequin closed this as completed Oct 28, 2003
    @calvin calvin mannequin added the stdlib Python modules in the Lib dir label Oct 28, 2003
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Oct 31, 2003

    Logged In: YES
    user_id=21627

    Can you provide a patch (including documentation changes)?

    @calvin
    Copy link
    Mannequin Author

    calvin mannequin commented Oct 31, 2003

    Logged In: YES
    user_id=9205

    Yes, in a few days.

    @calvin
    Copy link
    Mannequin Author

    calvin mannequin commented Nov 11, 2003

    Logged In: YES
    user_id=9205

    Here is a patch against CVS adding skip_accept_encoding and
    documentation.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 19, 2003

    Logged In: YES
    user_id=21627

    Thanks for the patch. Applied as

    libhttplib.tex 1.36
    httplib.py 1.82
    NEWS 1.895

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants