Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncore.dispatcher.set_reuse_addr() is broken on windows #40483

Closed
garth42 mannequin opened this issue Jun 30, 2004 · 5 comments
Closed

asyncore.dispatcher.set_reuse_addr() is broken on windows #40483

garth42 mannequin opened this issue Jun 30, 2004 · 5 comments
Assignees
Labels
stdlib Python modules in the Lib dir

Comments

@garth42
Copy link
Mannequin

garth42 mannequin commented Jun 30, 2004

BPO 982681
Nosy @tim-one, @akuchling
Files
  • asyncore.py.patch: asyncore.py patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/akuchling'
    closed_at = <Date 2004-08-13.22:47:23.000>
    created_at = <Date 2004-06-30.11:14:00.000>
    labels = ['library']
    title = 'asyncore.dispatcher.set_reuse_addr() is broken on windows'
    updated_at = <Date 2004-08-13.22:47:23.000>
    user = 'https://bugs.python.org/garth42'

    bugs.python.org fields:

    activity = <Date 2004-08-13.22:47:23.000>
    actor = 'tim.peters'
    assignee = 'akuchling'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2004-06-30.11:14:00.000>
    creator = 'garth42'
    dependencies = []
    files = ['6065']
    hgrepos = []
    issue_num = 982681
    keywords = ['patch']
    message_count = 5.0
    messages = ['46280', '46281', '46282', '46283', '46284']
    nosy_count = 3.0
    nosy_names = ['tim.peters', 'akuchling', 'garth42']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue982681'
    versions = ['Python 2.4']

    @garth42
    Copy link
    Mannequin Author

    garth42 mannequin commented Jun 30, 2004

    asyncore.dispatcher.set_reuse_addr() uses
    socket.SO_REUSEADDR to allow reuse of same address
    without having to wait.

    On windows this also allows multiple programs to bind
    to the same socket adress. What is probably needed is
    to use SO_EXCLUSIVEADDRUSE on windows which has the
    same meaning as SO_REUSEADDR on all other platforms.

    This will stop people running the server multiple times
    and getting wierd results or two programs sharing the
    same port without realising.

    @garth42 garth42 mannequin closed this as completed Jun 30, 2004
    @garth42 garth42 mannequin assigned akuchling Jun 30, 2004
    @garth42 garth42 mannequin added the stdlib Python modules in the Lib dir label Jun 30, 2004
    @garth42 garth42 mannequin closed this as completed Jun 30, 2004
    @garth42 garth42 mannequin assigned akuchling Jun 30, 2004
    @garth42 garth42 mannequin added the stdlib Python modules in the Lib dir label Jun 30, 2004
    @garth42
    Copy link
    Mannequin Author

    garth42 mannequin commented Jun 30, 2004

    Logged In: YES
    user_id=45280

    this depends on patch bpo-982665

    @akuchling
    Copy link
    Member

    Logged In: YES
    user_id=11375

    Checked into CVS; thanks.

    @akuchling
    Copy link
    Member

    Logged In: YES
    user_id=11375

    SO_EXCLUSIVEADDRUSE actually has quite different semantics
    from what SO_REUSEADDR is intended to be; backing out this
    change.

    @tim-one
    Copy link
    Member

    tim-one commented Aug 13, 2004

    Logged In: YES
    user_id=31435

    Noting that the patch broke the test suite for ZEO (Zope's
    networked-database layer on top of ZODB) on Windows.
    That all worked again after Andrew backed out the patch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants