Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypt module documentation extended #40641

Closed
fserb mannequin opened this issue Jul 25, 2004 · 2 comments
Closed

crypt module documentation extended #40641

fserb mannequin opened this issue Jul 25, 2004 · 2 comments
Labels
docs Documentation in the Doc dir

Comments

@fserb
Copy link
Mannequin

fserb mannequin commented Jul 25, 2004

BPO 997668
Nosy @loewis
Files
  • cryptdoc.patch: patch to extend crypt module documentation
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2004-07-26.12:07:12.000>
    created_at = <Date 2004-07-25.19:34:54.000>
    labels = ['docs']
    title = 'crypt module documentation extended'
    updated_at = <Date 2004-07-26.12:07:12.000>
    user = 'https://bugs.python.org/fserb'

    bugs.python.org fields:

    activity = <Date 2004-07-26.12:07:12.000>
    actor = 'loewis'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['Documentation']
    creation = <Date 2004-07-25.19:34:54.000>
    creator = 'fserb'
    dependencies = []
    files = ['6115']
    hgrepos = []
    issue_num = 997668
    keywords = ['patch']
    message_count = 2.0
    messages = ['46461', '46462']
    nosy_count = 2.0
    nosy_names = ['loewis', 'fserb']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue997668'
    versions = []

    @fserb
    Copy link
    Mannequin Author

    fserb mannequin commented Jul 25, 2004

    I thought there was some information missing on the
    crypt module documentation.

    I've changed two things basically.

    First, I made it clear that every extension (or general
    behavior) of the crypt(3) implementation on the running
    system will also be valid on the crypt module.

    Second, since some extensions (as the GNU extension on
    Linux) allows different values on the salt parameter,
    the whole crypted password should be used as salt when
    checking for a password. With this, I've corrected the
    example code to use the full cryptedpasswd instead of
    cryptedpasswd[:2]

    I would've changed the whole example to a simpler one.
    But left it to another patch.

    Since this is my first python patch, hope I've not made
    anything stupid.

    @fserb fserb mannequin closed this as completed Jul 25, 2004
    @fserb fserb mannequin added the docs Documentation in the Doc dir label Jul 25, 2004
    @fserb fserb mannequin closed this as completed Jul 25, 2004
    @fserb fserb mannequin added the docs Documentation in the Doc dir label Jul 25, 2004
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jul 26, 2004

    Logged In: YES
    user_id=21627

    Thanks for the patch, applied as libcrypt.tex 1.17 and
    1.16.36.1.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants