Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In DOM Node Objects, add more explanations for insertBefore #40909

Closed
madarche mannequin opened this issue Sep 14, 2004 · 3 comments
Closed

In DOM Node Objects, add more explanations for insertBefore #40909

madarche mannequin opened this issue Sep 14, 2004 · 3 comments
Labels
docs Documentation in the Doc dir

Comments

@madarche
Copy link
Mannequin

madarche mannequin commented Sep 14, 2004

BPO 1027771

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2004-11-07.19:56:45.000>
created_at = <Date 2004-09-14.08:53:50.000>
labels = ['docs']
title = 'In DOM Node Objects, add more explanations for insertBefore'
updated_at = <Date 2004-11-07.19:56:45.000>
user = 'https://bugs.python.org/madarche'

bugs.python.org fields:

activity = <Date 2004-11-07.19:56:45.000>
actor = 'jlgijsbers'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2004-09-14.08:53:50.000>
creator = 'madarche'
dependencies = []
files = []
hgrepos = []
issue_num = 1027771
keywords = []
message_count = 3.0
messages = ['22441', '22442', '22443']
nosy_count = 3.0
nosy_names = ['jlgijsbers', 'madarche', 'rodsenra']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1027771'
versions = ['Python 2.3']

@madarche
Copy link
Mannequin Author

madarche mannequin commented Sep 14, 2004

At
http://www.python.org/doc/2.3.4/lib/dom-node-objects.html#l2h-4071
current documentation is:

insertBefore(newChild, refChild)
    Insert a new child node before an existing child.
It must be the case that refChild is a child of this
node; if not, ValueError is raised. newChild is returned.

While it could be more complete:

insertBefore(newChild, refChild)
    Insert a new child node before an existing child.
It must be the case that refChild is a child of this
node; if not, ValueError is raised. newChild is
returned. If refChild is None, it inserts newChild at
the end of the list of children.

Note that node.insertAfter(newKid, refChild), if it
existed, would be precisely equivalent to
node.insertBefore(newKid,refChild.getNextSibling()).

@madarche madarche mannequin closed this as completed Sep 14, 2004
@madarche madarche mannequin closed this as completed Sep 14, 2004
@madarche madarche mannequin added docs Documentation in the Doc dir labels Sep 14, 2004
@rodsenra
Copy link
Mannequin

rodsenra mannequin commented Nov 7, 2004

Logged In: YES
user_id=9057

The patch 1062033 adds """
If refChild is None, it inserts newChild at
the end of the list of children.
""" to the xmldom.tex.

I left the last paragraph out of the patch, because I'm not
certain
it is clear enough or adequate.

@jlgijsbers
Copy link
Mannequin

jlgijsbers mannequin commented Nov 7, 2004

Logged In: YES
user_id=469548

Fixed by applying patch 1062033.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

No branches or pull requests

0 participants