tarfile.py longnames are truncated in getnames()

[gustaebel]

BPO	1029061
Nosy	@loewis, @gustaebel
Files	membernames.patch: patch against Lib/tarfile.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2004-09-18.09:09:31.000>
created_at = <Date 2004-09-16.08:44:18.000>
labels = ['library']
title = 'tarfile.py longnames are truncated in getnames()'
updated_at = <Date 2004-09-18.09:09:31.000>
user = 'https://github.com/gustaebel'

bugs.python.org fields:

activity = <Date 2004-09-18.09:09:31.000>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2004-09-16.08:44:18.000>
creator = 'lars.gustaebel'
dependencies = []
files = ['6254']
hgrepos = []
issue_num = 1029061
keywords = ['patch']
message_count = 2.0
messages = ['46908', '46909']
nosy_count = 2.0
nosy_names = ['loewis', 'lars.gustaebel']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1029061'
versions = ['Python 2.4']

[gustaebel]

When a TarFile object reads a tar archive, it scans
through the headers, converts them into TarInfo objects
and adds them to the internal data structures:

self.members.append(tarinfo)
self.membernames.append(tarinfo.name)

When a GNU longname member is processed, it is added at
a point in time when its name attribute has not yet
been replaced with the longname, so longnames in
self.membernames are truncated and therefore unusable.

This problem could have been fixed with a quick/dirty
hack. But I decided to remove self.membernames
completely because it is redundant. getnames() which
was the public interface to it now generates a list
on-the-fly from the list of members, so it always
reflects the actual state.

I encountered another small bug on the way. The docs
for TarFile.getmember() state: "If a member occurs more
than once in the archive, its last occurence is assumed
to be the most up-to-date version."
It was never implemented like that, so I fixed it, too.

[loewis]

Logged In: YES
user_id=21627

Thanks for the patch. Applied as

tarfile.py 1.20
NEWS 1.1137