codecs.StreamReader.readlines() broken

[thomaswaldmann]

BPO	1048865
Nosy	@hyeshik

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/hyeshik'
closed_at = <Date 2004-10-17.23:52:33.000>
created_at = <Date 2004-10-17.21:40:55.000>
labels = ['library']
title = 'codecs.StreamReader.readlines() broken'
updated_at = <Date 2004-10-17.23:52:33.000>
user = 'https://bugs.python.org/thomaswaldmann'

bugs.python.org fields:

activity = <Date 2004-10-17.23:52:33.000>
actor = 'hyeshik.chang'
assignee = 'hyeshik.chang'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2004-10-17.21:40:55.000>
creator = 'thomaswaldmann'
dependencies = []
files = []
hgrepos = []
issue_num = 1048865
keywords = []
message_count = 2.0
messages = ['22735', '22736']
nosy_count = 2.0
nosy_names = ['hyeshik.chang', 'thomaswaldmann']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1048865'
versions = ['Python 2.4']

[thomaswaldmann]

This is a quite obvious one:

$ diff -u codecs.py-orig codecs.py 
--- codecs.py-orig      2004-10-17 23:30:50.000000000 +0200
+++ codecs.py   2004-10-17 23:31:57.000000000 +0200
@@ -334,7 +334,7 @@
 
         """
         data = self.read()
-        return self.splitlines(keepends)
+        return data.splitlines(keepends)
 
     def reset(self):
 
I am using Python 2.4 beta 1.

[hyeshik]

Logged In: YES
user_id=55188

Thanks for the reporting.
Fixed in CVS:
Lib/codecs.py 1.35
Lib/test/test_codecs.py 1.14