fix for bug 1055168 (pdb not entering the right frame)

[isandler]

BPO	1061767
Files	pdb.patch3

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2004-11-07.11:37:58.000>
created_at = <Date 2004-11-07.04:26:18.000>
labels = ['library']
title = 'fix for bug 1055168 (pdb not entering the right frame)'
updated_at = <Date 2004-11-07.11:37:58.000>
user = 'https://bugs.python.org/isandler'

bugs.python.org fields:

activity = <Date 2004-11-07.11:37:58.000>
actor = 'jlgijsbers'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2004-11-07.04:26:18.000>
creator = 'isandler'
dependencies = []
files = ['6341']
hgrepos = []
issue_num = 1061767
keywords = ['patch']
message_count = 3.0
messages = ['47219', '47220', '47221']
nosy_count = 2.0
nosy_names = ['isandler', 'jlgijsbers']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1061767'
versions = []

[isandler]

Bdb.set_trace() assumed that the frame which needs to
be debugged is the caller's frame. This assumption
fails if Bdb_set_trace() is called from inside a
debugger (say from inside of a pdb's set_trace). So now
Bdb.set_trace() accepts an optional parameter
frame_to_debug which allows the caller to specify which
frame needs to be debugged, and pdb is modified to use it..

[isandler]

Logged In: YES
user_id=971153

The original bug report gives an example where the code to
debug was specified from python's shell. I am not quite how
pdb is supposed to behave in this case.. With the patch, it
does seem to enter in the right frame, but it can't list the
code.

The patch does work when the code comes from a file.

.def foo():
import pdb
pdb.set_trace()
print "tracing 1"
print "tracing 2"
foo()

[jlgijsbers]

Logged In: YES
user_id=469548

That's normal: pdb can never list code that was input on a
console. A coworker of mine (Jeroen Vloothuis) and I
beautified the code a bit, and I checked it in as rev 1.73
of pdb.py and rev 1.47 of bdb.py. Thanks for the patch!