Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon.File.FSCatalogInfo.createDate implementation #41356

Closed
ronaldoussoren opened this issue Dec 22, 2004 · 2 comments
Closed

Carbon.File.FSCatalogInfo.createDate implementation #41356

ronaldoussoren opened this issue Dec 22, 2004 · 2 comments
Assignees
Labels

Comments

@ronaldoussoren
Copy link
Contributor

BPO 1089624
Nosy @jackjansen, @ronaldoussoren

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/jackjansen'
closed_at = <Date 2009-03-30.22:52:08.148>
created_at = <Date 2004-12-22.09:51:03.000>
labels = ['OS-mac']
title = 'Carbon.File.FSCatalogInfo.createDate implementation'
updated_at = <Date 2009-03-30.22:52:08.147>
user = 'https://github.com/ronaldoussoren'

bugs.python.org fields:

activity = <Date 2009-03-30.22:52:08.147>
actor = 'ronaldoussoren'
assignee = 'jackjansen'
closed = True
closed_date = <Date 2009-03-30.22:52:08.148>
closer = 'ronaldoussoren'
components = ['macOS']
creation = <Date 2004-12-22.09:51:03.000>
creator = 'ronaldoussoren'
dependencies = []
files = []
hgrepos = []
issue_num = 1089624
keywords = []
message_count = 2.0
messages = ['60619', '84699']
nosy_count = 2.0
nosy_names = ['jackjansen', 'ronaldoussoren']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1089624'
versions = ['Python 2.4']

@ronaldoussoren
Copy link
Contributor Author

In Mac/Modules/file/_Filemodule.c UTCDateTime values are 
converted using these functions:
 
static int
UTCDateTime_Convert(PyObject *v, UTCDateTime *ptr)
{
        return PyArg_Parse(v, "(HlH)", &ptr->highSeconds, &ptr-
>lowSeconds, &ptr->fraction);
}

static PyObject *
UTCDateTime_New(UTCDateTime *ptr)
{
        return Py_BuildValue("(HlH)", ptr->highSeconds, ptr-
>lowSeconds, ptr->fraction);
}

Shouldn't the format string be "(HLH)" in both cases? The struct
definition of UTCDateTime contains unsigned times (UInt16, UInt32
and UInt16).

The same problem is present in Python 2.3

@ronaldoussoren
Copy link
Contributor Author

Closing this as won't fix. Nobody else complained and changing this might
break existing code.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants