New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single-line option to pygettext.py #41413
Comments
i added an option that make pygettext consider certain You can select which keywords trigger this special I use it something like this: POTCMD = pygettext.py \
--verbose --extract-all --no-default-keywords \
--keyword-single=_ --keyword-single=N_ \
--keyword=__
... pot:
$(POTCMD) -d $(PROJECT) -p $(dir $@) $(PYFILES) cheers, |
Logged In: NO Code review.... You have a few lines like : You use the single line option value as part of the key in __messages (assuming --keyword=_normal --keyword-single=_single) You also get duplicates for: _single("""this is one line and _single("""this is one line and because normalization is performed just before output. Unless Im |
Is this change still useful for 2.6? |
A rare example of a 5-year old patch that still applies with only a minor tweak. This is probably a sign that pygettext itself has not been kept up to date. In any case, I am attaching an updated patch which I did not test beyond running pygettext.py -h. There was no response from OP to the patch review and from a brief look at the patch, it is not commit ready. I am adding this as a dependency to meta-issue bpo-7962 so that the fate of this patch and pygettext itself can be decided. |
My gut reaction is that pygettext should be deprecated, other opinions are welcome. |
New changeset 4fe87b5df2d0 by Andrew Kuchling in branch '3.3': |
I've applied a patch from bpo-8502 that doesn't encourage the use of pygettext.py so strongly. I raised the issue of deprecating pygettext.py on python-dev on Nov 11 2013; the thread starts at <https://mail.python.org/pipermail/python-dev/2013-November/130123.html\>. Barry Warsaw and Philip Jenvey suggested deprecating it; Martin von Loewis was OK with continuing to maintain pygettext. So I'll leave this issue open, in case anyone wants to review the patch and commit it. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: