send/recv SEGMENT_SIZE should be used more in socketmodule

[irmen]

BPO	1103350
Nosy	@irmen, @devdanzin, @tjguk, @bitdancer, @briancurtin, @erlend-aasland

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2005-01-16.15:01:11.000>
labels = ['extension-modules', 'type-feature']
title = 'send/recv SEGMENT_SIZE should be used more in socketmodule'
updated_at = <Date 2021-03-15.09:58:09.165>
user = 'https://github.com/irmen'

bugs.python.org fields:

activity = <Date 2021-03-15.09:58:09.165>
actor = 'erlendaasland'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2005-01-16.15:01:11.000>
creator = 'irmen'
dependencies = []
files = []
hgrepos = []
issue_num = 1103350
keywords = []
message_count = 8.0
messages = ['60634', '60635', '82111', '114398', '114485', '115605', '127745', '388721']
nosy_count = 6.0
nosy_names = ['irmen', 'ajaksu2', 'tim.golden', 'r.david.murray', 'brian.curtin', 'erlendaasland']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1103350'
versions = ['Python 3.3']

[irmen]

socketmodule.c contains a SEGMENT_SIZE define that is
used to limit the send/recv buffer size on VMS.

But IMO there are two problems:

1. it should also be used on windows, because windows
   doesn't like a large send/recv buffer either,
2. it should be used in more places: at least sendall,
   but perhaps also recvfrom, sendto

ad 1: see also this bug: http://www.python.org/sf/853507

[irmen]

Logged In: YES
user_id=129426

Btw: I'm not too experienced with Win32 programming and so I
don't have a very good argumentation for the buffer size issue
on this platform. If there is somebody with better understanding
of the issues involved here, please advise.
(it's just empirical knowledge that I have that leads me to
believe that win32's tcp implementation suffers from similar
recv/send size problems as VMS does-- for which a special
case was made in the code)

[devdanzin]

Any clarifications on this RFE's merit appreciated.

[BreamoreBoy]

Is there any interest in this?

[BreamoreBoy]

I'll close this in a couple of weeks unless anyone objects.

[BreamoreBoy]

No reply to msg114485.

[bitdancer]

Looks like this was closed due to lack of appropriate people reviewing it, rather than because such a review was done.

[erlend-aasland]

FYI, the SEGMENT_SIZE define was removed by af01f66 (bpo-16136).

[arhadthedev]

@erlend-aasland Can the issue be closed then? I grepped for SEGMENT_SIZE in Modules/ and got no match.

[erlend-aasland]

The OP says it "should be used more on Windows". I don't know Windows, so I can't answer that. I observe that the person who opened this issue does not know Windows either.

Wild guess: the devs who wrote the socket module code in the first place probably know better than both me and the issue reporter, so I think the code is fine as it is (that is: we can close this). Maybe @zooba or @eryksun could chime in.

[zooba]

It's meaningless to me, and without a more compelling case, I'm not going to research it.