Can't build Zope on Windows w/ 2.4.1c1

[tim-one]

BPO	1160802
Nosy	@tim-one

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tim-one'
closed_at = <Date 2005-03-11.17:23:59.000>
created_at = <Date 2005-03-10.18:09:36.000>
labels = ['library', 'release-blocker']
title = "Can't build Zope on Windows w/ 2.4.1c1"
updated_at = <Date 2005-03-11.17:23:59.000>
user = 'https://github.com/tim-one'

bugs.python.org fields:

activity = <Date 2005-03-11.17:23:59.000>
actor = 'tim.peters'
assignee = 'tim.peters'
closed = True
closed_date = None
closer = None
components = ['Distutils']
creation = <Date 2005-03-10.18:09:36.000>
creator = 'tim.peters'
dependencies = []
files = []
hgrepos = []
issue_num = 1160802
keywords = []
message_count = 4.0
messages = ['24525', '24526', '24527', '24528']
nosy_count = 1.0
nosy_names = ['tim.peters']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1160802'
versions = ['Python 2.4']

[tim-one]

See the python-dev thread with the same name, at

<http://mail.python.org/pipermail/python-dev/2005-
March/051995.html>

The PATH we build, when compiling C extensions,
keeps getting bigger until putenv() blows up. Zope
builds a lot of C extensions.

A simple but sane hack is adding a new:

. if p not in self.__paths:

guard inside the:

. for p in string.split(os.environ['path'], ';'):
. self.__paths.append(p)

loop in 2.4.1c1's msvccompiler.py's initialize() function.

[tim-one]

Logged In: YES
user_id=31435

On python-dev, AMK said:

"""
In distutils.msvccompiler:

   def __init__ (self, verbose=0, dry_run=0, force=0):
       ...
       self.initialized = False

   def compile(self, sources,
               output_dir=None, macros=None, 
include_dirs=None, debug=0,
               extra_preargs=None, extra_postargs=None, 
depends=None):

       if not self.initialized: self.initialize()
       ...

   def initialize(self):
       ... does not seem to set self.initialized to True!

I think the fix is to add 'self.initialized = True' to the
initialize() method, but can't test it (no Windows). This fix
should also go into 2.4.1-final, I expect.
"""

Adding that to the end of initialize() worked for me (and
ripping out my hack).

[tim-one]

Logged In: YES
user_id=31435

Assigned to me. I'll check in Andrew's fix Friday, pending
more testing. (Anthony approved this plan, BTW.)

[tim-one]

Logged In: YES
user_id=31435

Fixed, via AMK's suggestion:

Lib/distutils/msvccompiler.py 1.64.2.3
Misc/NEWS 1.1193.2.35

Not an issue for 2.5 (MSVCCompiler initialization is already
OK there).