Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler module didn't get updated for "class foo():pass" #41801

Closed
logistix mannequin opened this issue Apr 3, 2005 · 3 comments
Closed

compiler module didn't get updated for "class foo():pass" #41801

logistix mannequin opened this issue Apr 3, 2005 · 3 comments
Assignees
Labels
stdlib Python modules in the Lib dir

Comments

@logistix
Copy link
Mannequin

logistix mannequin commented Apr 3, 2005

BPO 1176012
Nosy @brettcannon
Files
  • compiler_fix.diff: Fix for compiler module
  • class_fix_for_parsermodule.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
    closed_at = <Date 2005-04-09.02:34:02.000>
    created_at = <Date 2005-04-03.21:21:19.000>
    labels = ['library']
    title = 'compiler module didn\'t get updated for "class foo():pass"'
    updated_at = <Date 2005-04-09.02:34:02.000>
    user = 'https://bugs.python.org/logistix'

    bugs.python.org fields:

    activity = <Date 2005-04-09.02:34:02.000>
    actor = 'brett.cannon'
    assignee = 'brett.cannon'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2005-04-03.21:21:19.000>
    creator = 'logistix'
    dependencies = []
    files = ['1661', '1662']
    hgrepos = []
    issue_num = 1176012
    keywords = []
    message_count = 3.0
    messages = ['24878', '24879', '24880']
    nosy_count = 2.0
    nosy_names = ['brett.cannon', 'logistix']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1176012'
    versions = ['Python 2.5']

    @logistix
    Copy link
    Mannequin Author

    logistix mannequin commented Apr 3, 2005

    Patch with fix and testcase is attached.

    @logistix logistix mannequin closed this as completed Apr 3, 2005
    @logistix logistix mannequin assigned brettcannon Apr 3, 2005
    @logistix logistix mannequin added the stdlib Python modules in the Lib dir label Apr 3, 2005
    @logistix
    Copy link
    Mannequin Author

    logistix mannequin commented Apr 3, 2005

    Logged In: YES
    user_id=699438

    The parser module didn't get corrected either. Here is
    another patch with test case for that.

    @brettcannon
    Copy link
    Member

    Logged In: YES
    user_id=357491

    OK, committed in rev. XXX for Modules/parsermodule.c, rev.
    XXX for Lib/test/test_parser.py, rev. XXX for
    Lib/compiler/transformer.py, and rev. XXX for
    Lib/test/test_compiler.py .

    Only change from patch to what was committed was changing
    the formatting for parsermodule.c to meet the coding
    standard and a bug where an assignment was being made
    instead of a comparison.

    Closed as fixed. Thanks, logistix.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant