lax error-checking in new-in-2.4 marshal stuff

[mwhudson]

BPO	1180997
Nosy	@mwhudson, @loewis

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/mwhudson'
closed_at = <Date 2005-06-13.18:29:42.000>
created_at = <Date 2005-04-11.19:53:23.000>
labels = ['interpreter-core']
title = 'lax error-checking in new-in-2.4 marshal stuff'
updated_at = <Date 2005-06-13.18:29:42.000>
user = 'https://github.com/mwhudson'

bugs.python.org fields:

activity = <Date 2005-06-13.18:29:42.000>
actor = 'mwh'
assignee = 'mwh'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2005-04-11.19:53:23.000>
creator = 'mwh'
dependencies = []
files = []
hgrepos = []
issue_num = 1180997
keywords = []
message_count = 4.0
messages = ['24999', '25000', '25001', '25002']
nosy_count = 2.0
nosy_names = ['mwh', 'loewis']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1180997'
versions = ['Python 2.4']

[mwhudson]

I realise one of the points of the TYPE_STRINGREF and so on stuff
was efficiency, but:

>>> marshal.loads('R') # TYPE_STRINGREF == 'R'
Segmentation fault

[loewis]

Logged In: YES
user_id=21627

I agree, and will try to work on a patch before 2.4.2.

[mwhudson]

Logged In: YES
user_id=6656

While I have your attention:

>>> marshal.loads("", 1)
Segmentation fault

This is the guilty line:

	if (!PyArg_ParseTuple(args, "s#|i:loads", &s, &n))

there's no pointer corresponding to the optional integer argument.

I'd just fix this, but I have too many local changes to make it easy :(

[mwhudson]

Logged In: YES
user_id=6656

This turned out to be easier to fix than I expected, so I fixed it.

Python/marshal.c revision 1.86
Lib/test/test_marshal.py revision 1.12