Trivial typo in unicodedata._getcode

[dsuch]

BPO	1213831
Nosy	@loewis, @rhettinger
Files	ucd_getcode_typo.diff: Fixed typo in unicodedata._getcode

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/loewis'
closed_at = <Date 2005-09-18.08:19:16.000>
created_at = <Date 2005-06-02.22:00:54.000>
labels = []
title = 'Trivial typo in unicodedata._getcode'
updated_at = <Date 2005-09-18.08:19:16.000>
user = 'https://bugs.python.org/dsuch'

bugs.python.org fields:

activity = <Date 2005-09-18.08:19:16.000>
actor = 'loewis'
assignee = 'loewis'
closed = True
closed_date = None
closer = None
components = ['None']
creation = <Date 2005-06-02.22:00:54.000>
creator = 'dsuch'
dependencies = []
files = ['6680']
hgrepos = []
issue_num = 1213831
keywords = ['patch']
message_count = 3.0
messages = ['48423', '48424', '48425']
nosy_count = 3.0
nosy_names = ['loewis', 'rhettinger', 'dsuch']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1213831'
versions = []

[dsuch]

Hi,
I think there's a typo in unicodedata module's _getcode
function.
Line 823 (today's CVS build) should be

if (L != -1 && V != -1 && T != -1 && pos-name == namelen) {

not

if (V != -1 && V != -1 && T != -1 && pos-name == namelen) {

as in attached patch.

[rhettinger]

Logged In: YES
user_id=80475

Martin, I believe this is your code.

[loewis]

Logged In: YES
user_id=21627

Thanks for the patch. Committed as

NEWS 1.1368
unicodedata.c 2.35
NEWS 1.1193.2.100
unicodedata.c 2.32.2.1