New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler package: "global a; a=5" #42251
Comments
The stdlib compiler package produces wrong code for Quick patch from Michael attached. |
Logged In: YES The compiler package contains several bugs along the lines Attached is a diff against the 2.4 maintenance head of
|
Logged In: YES These fixes should definitely go into 2.5, IMHO. If you |
Logged In: YES The patch appears to apply as it is on the CVS HEAD, with at most offsets of 10 lines, and test_compiler.py passes afterwards. I suppose that someone (else than me) needs to give the patch a quick review anyway, so feel free to consider it as a 2.4 + 2.5 patch. |
Armin, if you still care about the compiler package, could you (or some |
Sorry, I don't think many PyPy coders care about microoptimizations in |
Armin, this is not about micro-optimizations per se, but about fixing This was the first time I was using the compiler package and I think it |
On Sun, Mar 23, 2008 at 04:17:12PM +0000, Antoine Pitrou wrote:
I'm interested to update the compiler package but I'm short of time Neil |
Thanks Antoine for the clarification. The situation is that by now PyPy has found many many more bugs in |
Armin, it would be nice to merge back your work indeed. If you submit a |
On Tue, Mar 25, 2008 at 09:18:38AM +0000, Armin Rigo wrote:
I'm not sure it can go back into the stdlib since there doesn't seem
Indeed it would make no sense to redo that work. Can the version in Neil |
It seems to me that releasing it as a third-party package would be a In any case, whatever the decision (stdlib package or separate Something like running some selected non-controversial parts of the test |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: