UNIX mmap leaks file descriptors

[drylock]

BPO	1344508
Files	t.py: Test case

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2005-11-02.05:46:40.000>
created_at = <Date 2005-11-01.03:46:21.000>
labels = ['library']
title = 'UNIX mmap leaks file descriptors'
updated_at = <Date 2005-11-02.05:46:40.000>
user = 'https://bugs.python.org/drylock'

bugs.python.org fields:

activity = <Date 2005-11-02.05:46:40.000>
actor = 'nnorwitz'
assignee = 'nnorwitz'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2005-11-01.03:46:21.000>
creator = 'drylock'
dependencies = []
files = ['1828']
hgrepos = []
issue_num = 1344508
keywords = []
message_count = 2.0
messages = ['26771', '26772']
nosy_count = 2.0
nosy_names = ['nnorwitz', 'drylock']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1344508'
versions = ['Python 2.4']

[drylock]

The commit from 2.49 to 2.50 in Modules/mmapmodule.c
has made mmap under UNIX leak a file descriptor:

•   m_obj-\>fd = fd;
  

+ m_obj->fd = dup(fd);

The FD given is dup'ed in order to allow ftruncation
later, but no close of it is done in dealloc/close.

A test case attached, using lsof after some
mmaps/unmaps to show leak.

Version:

Python 2.4.2 (#2, Sep 29 2005, 00:23:59)
[GCC 4.0.2 (Debian 4.0.1-9)] on linux2

[nnorwitz]

Logged In: YES
user_id=33168

Thanks!

Committed revision 41366.
Committed revision 41367. (cleanup)
Committed revision 41368. (2.4)