selectmodule.c calls PyInt_AsLong without error checking

[luked]

BPO	1346533

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2005-11-03.05:11:46.000>
created_at = <Date 2005-11-03.01:54:05.000>
labels = ['library']
title = 'selectmodule.c calls PyInt_AsLong without error checking'
updated_at = <Date 2005-11-03.05:11:46.000>
user = 'https://bugs.python.org/luked'

bugs.python.org fields:

activity = <Date 2005-11-03.05:11:46.000>
actor = 'nnorwitz'
assignee = 'nnorwitz'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2005-11-03.01:54:05.000>
creator = 'luked'
dependencies = []
files = []
hgrepos = []
issue_num = 1346533
keywords = []
message_count = 2.0
messages = ['26790', '26791']
nosy_count = 2.0
nosy_names = ['nnorwitz', 'luked']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1346533'
versions = ['Python 2.4']

[luked]

selectmodule.c calls PyInt_AsLong without checking
whether the conversion produced an error.
This bug can cause an error to be reported at the wrong
point, eg:

Python 2.4.2 (#1, Nov  3 2005, 12:41:57)
[GCC 3.4.3-20050110 (Gentoo Linux 3.4.3.20050110,
ssp-3.4.3.20050110-0, pie-8.7 on linux2
Type "help", "copyright", "credits" or "license" for
more information.
>>> import select
>>> p = select.poll()
>>> p.register(0) # stdin
>>> p.poll(0x100000000)
[(0, 4)]
>>> 2 + 3
OverflowError: long int too large to convert to int
>>>

[nnorwitz]

Logged In: YES
user_id=33168

Thanks!

Committed revision 41388, 41389. (head)
Committed revision 41390. (2.4)