Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect incomplete readline implementation #42927

Closed
smontanaro opened this issue Feb 21, 2006 · 3 comments
Closed

Detect incomplete readline implementation #42927

smontanaro opened this issue Feb 21, 2006 · 3 comments
Labels
extension-modules C modules in the Modules dir

Comments

@smontanaro
Copy link
Contributor

BPO 1435651
Nosy @loewis, @smontanaro, @brettcannon
Files
  • setup.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2007-02-19.10:33:47.000>
    created_at = <Date 2006-02-21.04:33:20.000>
    labels = ['extension-modules']
    title = 'Detect incomplete readline implementation'
    updated_at = <Date 2007-02-19.10:33:47.000>
    user = 'https://github.com/smontanaro'

    bugs.python.org fields:

    activity = <Date 2007-02-19.10:33:47.000>
    actor = 'loewis'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2006-02-21.04:33:20.000>
    creator = 'skip.montanaro'
    dependencies = []
    files = ['7020']
    hgrepos = []
    issue_num = 1435651
    keywords = ['patch']
    message_count = 3.0
    messages = ['49552', '49553', '49554']
    nosy_count = 3.0
    nosy_names = ['loewis', 'skip.montanaro', 'brett.cannon']
    pr_nums = []
    priority = 'normal'
    resolution = 'rejected'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1435651'
    versions = ['Python 2.5']

    @smontanaro
    Copy link
    Contributor Author

    Here's a patch for setup.py to detect BSD-ish readlines that
    don't have the full suite of readline/history functions needed
    by Python (and provided by GNU readline).

    Skip

    @smontanaro smontanaro added the extension-modules C modules in the Modules dir label Feb 21, 2006
    @smontanaro smontanaro added the extension-modules C modules in the Modules dir label Feb 21, 2006
    @brettcannon
    Copy link
    Member

    Logged In: YES
    user_id=357491

    You mentioned on python-dev and in the diff that autoconf
    could detect this better. Would adding something to
    configure and having distutils.sysconfig.get_config_var()
    see if it is set be a better solution?

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Feb 19, 2007

    I'm rejecting this patch as out-of-date. r42562 added a similar change, although restricted to OSX.

    If anybody wants to work on it again, I recommend to add checks for exported functions to configure, then query them in setup.py (doing it in distutils is probably impractical, as you would want to cache the result, just as configure output is cached in config.status).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants