Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to rev 45325 #43197

Closed
smontanaro opened this issue Apr 13, 2006 · 5 comments
Closed

Alternative to rev 45325 #43197

smontanaro opened this issue Apr 13, 2006 · 5 comments
Assignees
Labels
build The build process and cross-build

Comments

@smontanaro
Copy link
Contributor

BPO 1469594
Nosy @loewis, @smontanaro
Files
  • compile.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/smontanaro'
    closed_at = <Date 2006-04-13.17:44:40.000>
    created_at = <Date 2006-04-13.02:11:51.000>
    labels = ['build']
    title = 'Alternative to rev 45325'
    updated_at = <Date 2006-04-13.17:44:40.000>
    user = 'https://github.com/smontanaro'

    bugs.python.org fields:

    activity = <Date 2006-04-13.17:44:40.000>
    actor = 'loewis'
    assignee = 'skip.montanaro'
    closed = True
    closed_date = None
    closer = None
    components = ['Build']
    creation = <Date 2006-04-13.02:11:51.000>
    creator = 'skip.montanaro'
    dependencies = []
    files = ['7148']
    hgrepos = []
    issue_num = 1469594
    keywords = ['patch']
    message_count = 5.0
    messages = ['49987', '49988', '49989', '49990', '49991']
    nosy_count = 3.0
    nosy_names = ['loewis', 'skip.montanaro', 'anthonybaxter']
    pr_nums = []
    priority = 'normal'
    resolution = 'out of date'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1469594'
    versions = ['Python 2.5']

    @smontanaro
    Copy link
    Contributor Author

    Here's an alternative to Anthony's cast in rev 45325. Is this any
    better than a simple cast? I think it should probably have a
    _SET_ENUM macro as well to set enum values through the union as well.

    Skip

    @smontanaro smontanaro self-assigned this Apr 13, 2006
    @smontanaro smontanaro added the build The build process and cross-build label Apr 13, 2006
    @smontanaro smontanaro self-assigned this Apr 13, 2006
    @smontanaro smontanaro added the build The build process and cross-build label Apr 13, 2006
    @anthonybaxter
    Copy link
    Mannequin

    anthonybaxter mannequin commented Apr 13, 2006

    Logged In: YES
    user_id=29957

    looks ok to me. feel free to check in.

    @smontanaro
    Copy link
    Contributor Author

    Logged In: YES
    user_id=44345

    Checked in as revision 45354

    @smontanaro
    Copy link
    Contributor Author

    Logged In: YES
    user_id=44345

    I'm reopening this. My patch broke the C build. I reverted
    the change in SVN and will investigate further.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Apr 13, 2006

    Logged In: YES
    user_id=21627

    A yet different alternative was committed as r45360

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant