Quitter object masked

[jimjjewett]

BPO	1479785
Nosy	@kbkaiser, @ronaldoussoren

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kbkaiser'
closed_at = <Date 2007-02-05.17:40:49.000>
created_at = <Date 2006-05-01.15:01:40.000>
labels = ['expert-IDLE']
title = 'Quitter object masked'
updated_at = <Date 2007-02-05.17:40:49.000>
user = 'https://bugs.python.org/jimjjewett'

bugs.python.org fields:

activity = <Date 2007-02-05.17:40:49.000>
actor = 'kbk'
assignee = 'kbk'
closed = True
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2006-05-01.15:01:40.000>
creator = 'jimjjewett'
dependencies = []
files = []
hgrepos = []
issue_num = 1479785
keywords = []
message_count = 4.0
messages = ['28398', '28399', '28400', '28401']
nosy_count = 3.0
nosy_names = ['kbk', 'jimjjewett', 'ronaldoussoren']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1479785'
versions = ['Python 2.5']

[jimjjewett]

2.5 introduces a Quitter object (defined in site.py)
to make the quit/exit message more friendly.

Lines 480-482 of PyShell.py override this, so that
users of Idle never see the improved feature.

Unfortunately, simply removing those lines isn't quite
enough to solve the problem, as IDLE catches
SystemExit exceptions. Getting around that, I didn't
have time to track down yet.

[kbkaiser]

Logged In: YES
user_id=149084

Rev 51306: Patch bpo-1540892

[ronaldoussoren]

Logged In: YES
user_id=580910

When I type quit() in the Python Shell window I get a dialog that says:

The program is still running!
Do you want to kill it?

(Python 2.5c1)

[kbkaiser]

I don't see how to easily eliminate the dialog. When quit() runs, Quitter.__call__() closes IDLE's sys.stdin, and (since __call__() is still executing) that's trapped by PyShell.py using the logic which requires the user to confirm exit if he clicks on the Shell's close widget (WM_DELETE_WINDOW) while his code is running. If File.close() had a parameter, we might be able to do something about this.

The extra confirmation probably doesn't hurt. Aficionados will use Ctrl-D etc. anyway.