Remove randomness from test_exceptions

[zseil]

BPO	1501987
Nosy	@tim-one
Files	test_exceptions.diff: patch against revision 46702

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2006-06-07.07:00:17.000>
created_at = <Date 2006-06-07.03:09:23.000>
labels = ['tests']
title = 'Remove randomness from test_exceptions'
updated_at = <Date 2006-06-07.07:00:17.000>
user = 'https://bugs.python.org/zseil'

bugs.python.org fields:

activity = <Date 2006-06-07.07:00:17.000>
actor = 'tim.peters'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2006-06-07.03:09:23.000>
creator = 'zseil'
dependencies = []
files = ['7317']
hgrepos = []
issue_num = 1501987
keywords = ['patch']
message_count = 2.0
messages = ['50441', '50442']
nosy_count = 2.0
nosy_names = ['tim.peters', 'zseil']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1501987'
versions = ['Python 2.5']

[zseil]

Recently test_exceptions was reporting random
memory leaks. It seems that this was caused
by the pickling part of testAttributes, which
uses a random integer for pickling protocol.
With this patch applied, I couldn't reproduce
the leak anymore, although I didn't run it 666
times.
The patch also includes a fix for the pickling
part of the test (previously it was checking
the attributes of the original exception, not
the unpickled one), removes another unused
import and moves all the imports to the
top of the file.

[tim-one]

Logged In: YES
user_id=31435

Woo hoo! This appears to cure the oddball "leaks" for me
too, but no idea why. Outstanding anyway ;-)

I fiddled the patch a bit to exercise both pickle and
cPickle, and to use pickle.HIGHEST_PROTOCOL instead of the
hardcoded 2. Checked in as revision 46705 on the trunk.
Thank you!