Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional compilation of zlib.(de)compressobj.copy #43474

Closed
catlee mannequin opened this issue Jun 8, 2006 · 3 comments
Closed

Conditional compilation of zlib.(de)compressobj.copy #43474

catlee mannequin opened this issue Jun 8, 2006 · 3 comments
Labels
extension-modules C modules in the Modules dir

Comments

@catlee
Copy link
Mannequin

catlee mannequin commented Jun 8, 2006

BPO 1503046
Nosy @catlee
Files
  • zlib-conditional.patch: Patch against r46756 to add copy methods to (de)compression objects only if the zlib library supports it
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2006-06-12.03:36:04.000>
    created_at = <Date 2006-06-08.17:22:06.000>
    labels = ['extension-modules']
    title = 'Conditional compilation of zlib.(de)compressobj.copy'
    updated_at = <Date 2006-06-12.03:36:04.000>
    user = 'https://github.com/catlee'

    bugs.python.org fields:

    activity = <Date 2006-06-12.03:36:04.000>
    actor = 'nnorwitz'
    assignee = 'nnorwitz'
    closed = True
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2006-06-08.17:22:06.000>
    creator = 'catlee'
    dependencies = []
    files = ['7318']
    hgrepos = []
    issue_num = 1503046
    keywords = ['patch']
    message_count = 3.0
    messages = ['50443', '50444', '50445']
    nosy_count = 2.0
    nosy_names = ['nnorwitz', 'catlee']
    pr_nums = []
    priority = 'high'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1503046'
    versions = []

    @catlee
    Copy link
    Mannequin Author

    catlee mannequin commented Jun 8, 2006

    First pass at a patch to only compile the new copy()
    methods for (de)compression objects in zlib if the zlib
    library supports them.

    I ran autoheader to pick up the AC_DEFINE from
    configure.in, and it looks like it changed
    pyconfig.h.in quite a bit. Probably the only part that
    needs to stay in is the #undef ZLIB_HAS_COPY part.

    If inflateCopy() is not found in the zlib library, then
    the copy() methods are not compiled.

    Lib/test_zlib.py has been updated to only test these
    methods if they exist.

    @catlee catlee mannequin closed this as completed Jun 8, 2006
    @catlee catlee mannequin assigned nnorwitz Jun 8, 2006
    @catlee catlee mannequin added the extension-modules C modules in the Modules dir label Jun 8, 2006
    @catlee catlee mannequin closed this as completed Jun 8, 2006
    @catlee catlee mannequin assigned nnorwitz Jun 8, 2006
    @catlee catlee mannequin added the extension-modules C modules in the Modules dir label Jun 8, 2006
    @nnorwitz
    Copy link
    Mannequin

    nnorwitz mannequin commented Jun 12, 2006

    Logged In: YES
    user_id=33168

    Thanks! I changed ZLIB_HAS_COPY to HAVE_ZLIB_COPY to be
    more consistent with the rest of pyconfig.h.in.

    Committed revision 46886.

    1 similar comment
    @nnorwitz
    Copy link
    Mannequin

    nnorwitz mannequin commented Jun 12, 2006

    Logged In: YES
    user_id=33168

    Thanks! I changed ZLIB_HAS_COPY to HAVE_ZLIB_COPY to be
    more consistent with the rest of pyconfig.h.in.

    Committed revision 46886.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants