Patch for 1496501 tarfile opener order

[jackdied]

BPO	1504073
Nosy	@gustaebel, @jackdied
Files	tarfile_order.diff: tarfile and test_tarfile patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gustaebel'
closed_at = <Date 2006-12-27.10:38:19.000>
created_at = <Date 2006-06-10.17:45:15.000>
labels = []
title = 'Patch for 1496501 tarfile opener order'
updated_at = <Date 2006-12-27.10:38:19.000>
user = 'https://github.com/jackdied'

bugs.python.org fields:

activity = <Date 2006-12-27.10:38:19.000>
actor = 'lars.gustaebel'
assignee = 'lars.gustaebel'
closed = True
closed_date = None
closer = None
components = ['None']
creation = <Date 2006-06-10.17:45:15.000>
creator = 'jackdied'
dependencies = []
files = ['7323']
hgrepos = []
issue_num = 1504073
keywords = ['patch']
message_count = 2.0
messages = ['50456', '50457']
nosy_count = 2.0
nosy_names = ['lars.gustaebel', 'jackdied']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1504073'
versions = []

[jackdied]

when passing a fileobj into tarfile.open() without
specifying the type open() will try openers in their
dict key order from TarFile.OPEN_METH. This can fail
if the order changes.

This patch adds a tell() and seek() on failure of
openers. fileobjs must already support these methods
to work so this makes no new requirements.

OpenOrderTest uses a dict-alike with shuffled keys to
try and provoke the wrong orders for openers.

Let me know if it looks good and I'll check it in.

[gustaebel]

Made the testcase simpler and checked it in as rev. 53161 and rev. 53162 (2.5).