Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher reset to factory button provides bad command-line #44079

Closed
jejackson mannequin opened this issue Oct 3, 2006 · 5 comments
Closed

Launcher reset to factory button provides bad command-line #44079

jejackson mannequin opened this issue Oct 3, 2006 · 5 comments
Assignees
Labels

Comments

@jejackson
Copy link
Mannequin

jejackson mannequin commented Oct 3, 2006

BPO 1570284
Nosy @ronaldoussoren

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/ronaldoussoren'
closed_at = <Date 2006-10-24.02:20:06.000>
created_at = <Date 2006-10-03.21:17:48.000>
labels = ['OS-mac']
title = 'Launcher reset to factory button provides bad command-line'
updated_at = <Date 2006-10-24.02:20:06.000>
user = 'https://bugs.python.org/jejackson'

bugs.python.org fields:

activity = <Date 2006-10-24.02:20:06.000>
actor = 'sf-robot'
assignee = 'ronaldoussoren'
closed = True
closed_date = None
closer = None
components = ['macOS']
creation = <Date 2006-10-03.21:17:48.000>
creator = 'jejackson'
dependencies = []
files = []
hgrepos = []
issue_num = 1570284
keywords = []
message_count = 5.0
messages = ['30149', '30150', '30151', '30152', '30153']
nosy_count = 4.0
nosy_names = ['nnorwitz', 'sf-robot', 'ronaldoussoren', 'jejackson']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1570284'
versions = ['Python 2.5']

@jejackson
Copy link
Mannequin Author

jejackson mannequin commented Oct 3, 2006

If I push the "Reset to factory settings" in Python Launcher's Preferences
window, the command line gets a bogues "(null)" inserted, which makes a
mess of things. I don't think that was what was intended.

In trying to debug this, I notice in the source for FileSettings.m, at line
209
there are two duplicated lines:

        [NSNumber numberWithBool: nosite], @"nosite",
        [NSNumber numberWithBool: nosite], @"nosite",

Also, I notice at FileSettings.m:236

    value = [dict objectForKey: @"nosite"];
    if (value) nosite = [value boolValue];
    value = [dict objectForKey: @"nosite"];
    if (value) tabs = [value boolValue];

I'm wondering if these second "nosite"s should be "tabs", and if that
would fix the problem.

@jejackson jejackson mannequin closed this as completed Oct 3, 2006
@jejackson jejackson mannequin assigned ronaldoussoren Oct 3, 2006
@jejackson jejackson mannequin added the OS-mac label Oct 3, 2006
@jejackson jejackson mannequin closed this as completed Oct 3, 2006
@jejackson jejackson mannequin assigned ronaldoussoren Oct 3, 2006
@jejackson jejackson mannequin added the OS-mac label Oct 3, 2006
@nnorwitz
Copy link
Mannequin

nnorwitz mannequin commented Oct 4, 2006

Logged In: YES
user_id=33168

Ronald, I'm guessing that Jack still doesn't have time. Do
you know anything about this?

@ronaldoussoren
Copy link
Contributor

Logged In: YES
user_id=580910

I'll have a look at this this weekend. On first glance the analysis for the source
code looks correct and both lines should be changed, but I don't have time just
ow to do this and test the results just now (and then backport to the 2.5 and 2.4
trees)

P.S. I'll be doing a huge checking on the 2.4 branch this weekend, backporting
the universal python stuff to the official tree. Last week was busier than
expected, hence the late checkin.

@ronaldoussoren
Copy link
Contributor

Logged In: YES
user_id=580910

Fixed in revision 52229 (trunk), 52230 (2.5 branch) and 52231/52232 (2.4
branch).

The latter checkin is a lot larger than just this fix, it is a backport of the entire
universal binary support code from 2.5 to the official 2.4 tree (the 2.4.3.
installer was build from an out-of-tree "branch").

@sf-robot
Copy link
Mannequin

sf-robot mannequin commented Oct 24, 2006

Logged In: YES
user_id=1312539

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant