Modules/readline.c fails to compile on AIX 4.2

[mikent]

BPO	1597798
Nosy	@akuchling, @devdanzin

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-04-25.21:39:34.995>
created_at = <Date 2006-11-16.15:37:41.000>
labels = ['type-bug', 'build']
title = 'Modules/readline.c fails to compile on AIX 4.2'
updated_at = <Date 2009-04-25.21:39:34.994>
user = 'https://bugs.python.org/mikent'

bugs.python.org fields:

activity = <Date 2009-04-25.21:39:34.994>
actor = 'ajaksu2'
assignee = 'none'
closed = True
closed_date = <Date 2009-04-25.21:39:34.995>
closer = 'ajaksu2'
components = ['Build']
creation = <Date 2006-11-16.15:37:41.000>
creator = 'mikent'
dependencies = []
files = []
hgrepos = []
issue_num = 1597798
keywords = []
message_count = 3.0
messages = ['61036', '61037', '84584']
nosy_count = 3.0
nosy_names = ['akuchling', 'mikent', 'ajaksu2']
pr_nums = []
priority = 'low'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1597798'
versions = ['Python 2.6']

[mikent]

Python 2.5 Modules/readline.c line 681 is:

return completion_matches(text, \*on_completion);

on_completion is a function declared as:

static char *on_completion(char *text, int state);

completion_matches is a macro that expands to:

rl_completion_matches((x), ((rl_compentry_func_t *)(y)))

SO, the second parameter to completion_matches should be a function pointer (on_completion), not the dereferenced function pointer that is currently passed to it (*on_completion).

[akuchling]

Can you please provide a patch that fixes things? It's difficult for us to provide a patch that will fix the problem on AIX because we don't have access to an AIX machine for testing.

[devdanzin]

I'll close this on lack of feedback unless someone voices opposition.