Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferred diff format should be mentioned as "unified". #44382

Closed
draghuram mannequin opened this issue Dec 27, 2006 · 2 comments
Closed

preferred diff format should be mentioned as "unified". #44382

draghuram mannequin opened this issue Dec 27, 2006 · 2 comments
Assignees
Labels
docs Documentation in the Doc dir

Comments

@draghuram
Copy link
Mannequin

draghuram mannequin commented Dec 27, 2006

BPO 1623153
Nosy @rhettinger, @facundobatista

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/facundobatista'
closed_at = <Date 2007-03-31.19:38:03.000>
created_at = <Date 2006-12-27.21:18:45.000>
labels = ['docs']
title = 'preferred diff format should be mentioned as "unified".'
updated_at = <Date 2007-03-31.19:38:03.000>
user = 'https://bugs.python.org/draghuram'

bugs.python.org fields:

activity = <Date 2007-03-31.19:38:03.000>
actor = 'rhettinger'
assignee = 'facundobatista'
closed = True
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2006-12-27.21:18:45.000>
creator = 'draghuram'
dependencies = []
files = []
hgrepos = []
issue_num = 1623153
keywords = []
message_count = 2.0
messages = ['30877', '30878']
nosy_count = 3.0
nosy_names = ['rhettinger', 'facundobatista', 'draghuram']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1623153'
versions = []

@draghuram
Copy link
Mannequin Author

draghuram mannequin commented Dec 27, 2006

The page at http://www.python.org/dev/tools/ mentions that context diffs are preferred. However, the link at http://www.python.org/dev/patches/ mentions that "We like unified diffs. We grudgingly accept contextual diffs.". So "tools" page should preferably mention unified diffs as well.

Thanks,
Raghu

@draghuram draghuram mannequin closed this as completed Dec 27, 2006
@draghuram draghuram mannequin added the docs Documentation in the Doc dir label Dec 27, 2006
@draghuram draghuram mannequin closed this as completed Dec 27, 2006
@draghuram draghuram mannequin added the docs Documentation in the Doc dir label Dec 27, 2006
@rhettinger
Copy link
Contributor

I don't think we really do care. Sometimes context diffs are easier to understand and sometimes unified diffs are the way to go depending on the patch. I say, let the world do what the world will do. No unnecessary rules.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

No branches or pull requests

2 participants