Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Py_PROTO from socket in py3k #44633

Closed
shredwheat mannequin opened this issue Feb 27, 2007 · 2 comments
Closed

Remove Py_PROTO from socket in py3k #44633

shredwheat mannequin opened this issue Feb 27, 2007 · 2 comments

Comments

@shredwheat
Copy link
Mannequin

shredwheat mannequin commented Feb 27, 2007

BPO 1670209
Files
  • nonetproto.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2008-01-06.22:29:46.181>
    created_at = <Date 2007-02-27.18:08:12.000>
    labels = []
    title = 'Remove Py_PROTO from socket in py3k'
    updated_at = <Date 2008-01-06.22:29:46.181>
    user = 'https://bugs.python.org/shredwheat'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:46.181>
    actor = 'admin'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['None']
    creation = <Date 2007-02-27.18:08:12.000>
    creator = 'shredwheat'
    dependencies = []
    files = ['7804']
    hgrepos = []
    issue_num = 1670209
    keywords = ['patch']
    message_count = 2.0
    messages = ['51993', '51994']
    nosy_count = 2.0
    nosy_names = ['nnorwitz', 'shredwheat']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1670209'
    versions = ['Python 3.0']

    @shredwheat
    Copy link
    Mannequin Author

    shredwheat mannequin commented Feb 27, 2007

    A few files used to build the socket module have Py_PROTO macros used for forward function declarations. These are preventing the socket module from compiling under cygwin.

    Searching the python code does not show these being defined anywhere under Py3k. In the 2.6 trunk it is defined in pyport.h

    @shredwheat shredwheat mannequin closed this as completed Feb 27, 2007
    @shredwheat shredwheat mannequin closed this as completed Feb 27, 2007
    @nnorwitz
    Copy link
    Mannequin

    nnorwitz mannequin commented Feb 27, 2007

    Committed revision 54001.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants