Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xreload.py won't update class docstrings #44739

Closed
jimjjewett mannequin opened this issue Mar 18, 2007 · 2 comments
Closed

xreload.py won't update class docstrings #44739

jimjjewett mannequin opened this issue Mar 18, 2007 · 2 comments
Assignees
Labels
stdlib Python modules in the Lib dir

Comments

@jimjjewett
Copy link
Mannequin

jimjjewett mannequin commented Mar 18, 2007

BPO 1683288
Nosy @gvanrossum

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2007-08-30.00:21:16.555>
created_at = <Date 2007-03-18.22:48:39.000>
labels = ['library']
title = "xreload.py won't update class docstrings"
updated_at = <Date 2008-01-06.22:29:46.813>
user = 'https://bugs.python.org/jimjjewett'

bugs.python.org fields:

activity = <Date 2008-01-06.22:29:46.813>
actor = 'admin'
assignee = 'gvanrossum'
closed = True
closed_date = <Date 2007-08-30.00:21:16.555>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2007-03-18.22:48:39.000>
creator = 'jimjjewett'
dependencies = []
files = []
hgrepos = []
issue_num = 1683288
keywords = []
message_count = 2.0
messages = ['31567', '55451']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'jimjjewett']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1683288'
versions = ['Python 3.0']

@jimjjewett
Copy link
Mannequin Author

jimjjewett mannequin commented Mar 18, 2007

"""
def _update_class(oldclass, newclass):
...
for name in oldnames & newnames - {"__dict__", "__doc__"}:
setattr(oldclass, name, _update(olddict[name], newdict[name]))
return oldclass
"""

I assume __doc__ is skipped because a string can't be updated in place. But since oldclass is returned, __doc__ should still be replaced with the updated documentation.

@jimjjewett jimjjewett mannequin assigned gvanrossum Mar 18, 2007
@jimjjewett jimjjewett mannequin added the stdlib Python modules in the Lib dir label Mar 18, 2007
@jimjjewett jimjjewett mannequin assigned gvanrossum Mar 18, 2007
@jimjjewett jimjjewett mannequin added the stdlib Python modules in the Lib dir label Mar 18, 2007
@gvanrossum
Copy link
Member

I'm not doing development on xreload ATM.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Development

No branches or pull requests

1 participant